Implement stop_reason #57
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that for some reason Ollama does not always respond with `done_reason`. So that needs to be investigated further
0x1eef
approved these changes
Nov 21, 2024
| @@ -20,6 +20,13 @@ def logprobs | |||
| @extra[:logprobs] | |||
| end | |||
|
|
|||
| ## | |||
There was a problem hiding this comment.
Can we link to some relevant docs - similar to logprobs ? Although there's more providers to cover this time
There was a problem hiding this comment.
@0x1eef should we just link to stop_reason from OpenAI? or link all of them? There's probably no generic docs for it
There was a problem hiding this comment.
If we could link to the relevant docs for each I think that'd be helpful - failing that, let's just reference OpenAI
0x1eef
reviewed
Mar 16, 2025
| LLM::Message.new( | ||
| _1.dig("content", "role"), | ||
| {text: _1.dig("content", "parts", 0, "text")} | ||
| {text: _1.dig("content", "parts", 0, "text")}, | ||
| {stop_reason:} |
There was a problem hiding this comment.
Can we write this as
{stop_reason: _1["stop_reason"]}| @@ -20,7 +20,8 @@ def parse_completion(raw) | |||
| { | |||
| model: raw["model"], | |||
| choices: raw["content"].map do | |||
| LLM::Message.new(raw["role"], _1["text"]) | |||
| stop_reason = raw["stop_reason"] | |||
| LLM::Message.new(raw["role"], _1["text"], {stop_reason:}) | |||
There was a problem hiding this comment.
Can we write this as:
{stop_reason: _1["stop_reason"]}| @@ -7,7 +7,7 @@ module ResponseParser | |||
| def parse_completion(raw) | |||
| { | |||
| model: raw["model"], | |||
| choices: [LLM::Message.new(*raw["message"].values_at("role", "content"))], | |||
| choices: [LLM::Message.new(*raw["message"].values_at("role", "content"), {stop_reason: raw["done_reason"]})], | |||
| @@ -19,7 +19,9 @@ def parse_completion(raw) | |||
| { | |||
| model: raw["model"], | |||
| choices: raw["choices"].map do | |||
| LLM::Message.new(*_1["message"].values_at("role", "content"), {logprobs: _1["logprobs"]}) | |||
| logprobs = _1["logprobs"] | |||
There was a problem hiding this comment.
Could this be:
logprobs, stop_reason = _1.values_at("logprobs", "finish_reason")| @@ -73,6 +73,10 @@ | |||
| total_tokens: 2598 | |||
| ) | |||
| end | |||
|
|
|||
| it "has stop reason" do | |||
There was a problem hiding this comment.
it "includes a stop reason" do
#..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
stop_reasontoLLM::Messagestop_reasonto Anthropic, Gemini, OpenAI and Ollama