Skip to content

[LTO] Fix System library path in LTO tests on macOS #144203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gcmicros
Copy link

Add explicit SDK library path (-L flag) to the System library in LTO tests
to fix the "library not found for -lSystem" error on macOS. This affects
the following test files:

  • tools/lto/print-stats.ll
  • tools/lto/hide-linkonce-odr.ll
  • tools/lto/discard-value-names.ll
  • tools/lto/opt-level.ll
  • tools/lto/no-bitcode.s

The tests now explicitly include the path to the macOS SDK's usr/lib directory
to ensure the linker can find the System library during test execution.

Add explicit SDK library path (-L flag) to the System library in LTO tests
to fix the "library not found for -lSystem" error on macOS. This affects
the following test files:
- tools/lto/print-stats.ll
- tools/lto/hide-linkonce-odr.ll
- tools/lto/discard-value-names.ll
- tools/lto/opt-level.ll
- tools/lto/no-bitcode.s

The tests now explicitly include the path to the macOS SDK's usr/lib directory
to ensure the linker can find the System library during test execution.
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant