Revert "[Cygwin] Define LLVM_ABI for Cygwin (#143222)" #144210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flang Merge CI rejects changes to llvm/Support/Compiler.h because precompiled headers aren't rebuilt when their dependencies change. This reverts commit 60d0004.
|
@llvm/pr-subscribers-llvm-support Author: Tomohiro Kashiwada (kikairoya) ChangesFlang Merge CI rejects changes to llvm/Support/Compiler.h because precompiled headers aren't rebuilt when their dependencies change. This reverts commit 60d0004. Full diff: https://github.com/llvm/llvm-project/pull/144210.diff 1 Files Affected:
diff --git a/llvm/include/llvm/Support/Compiler.h b/llvm/include/llvm/Support/Compiler.h
index 0de789ec68c49..f6bc05011e3c3 100644
--- a/llvm/include/llvm/Support/Compiler.h
+++ b/llvm/include/llvm/Support/Compiler.h
@@ -209,7 +209,7 @@
#define LLVM_ABI_FRIEND LLVM_ABI
#define LLVM_ABI_EXPORT __declspec(dllexport)
#elif defined(__ELF__) || defined(__MINGW32__) || defined(_AIX) || \
- defined(__MVS__) || defined(__CYGWIN__)
+ defined(__MVS__)
#define LLVM_ABI LLVM_ATTRIBUTE_VISIBILITY_DEFAULT
#define LLVM_ABI_FRIEND
#define LLVM_TEMPLATE_ABI LLVM_ATTRIBUTE_VISIBILITY_DEFAULT
|
|
This seems like a bug in the CI then, why revert this? |
|
I thought this should be applied after the CI script is fixed. If that's not necessary, I'll close this. |
|
I don't know - we'll see if somebody who does chimes in, but I wanted to clarify that this is really a CI bug. |
|
I'll leave this open for now, but I hope it can be resolved by fixing the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flang Merge CI rejects changes to llvm/Support/Compiler.h because precompiled headers aren't rebuilt when their dependencies change.
This reverts commit 60d0004.