[libc++] Avoid including vector in <functional> #144310
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vector
has been used in a very simple way inboyer_moore_searcher
. We can instead just useunique_ptr<T[]>
, which is a lot simpler, allowing us to drop thevector
dependency while not losing any expressiveness in the code. As a nice side effect, this also reduces the time it takes to instantiate theboyer_moore_searcher
constructor from 26ms to 22ms on my machine.