Skip to content

[libc++] Avoid including vector in <functional> #144310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

philnik777
Copy link
Contributor

@philnik777 philnik777 commented Jun 16, 2025

vector has been used in a very simple way in boyer_moore_searcher. We can instead just use unique_ptr<T[]>, which is a lot simpler, allowing us to drop the vector dependency while not losing any expressiveness in the code. As a nice side effect, this also reduces the time it takes to instantiate the boyer_moore_searcher constructor from 26ms to 22ms on my machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant