Skip to content

[JumpThreading] Invalidate LVI after combineMetadataForCSE. #65219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 4, 2023

Conversation

dianqk
Copy link
Member

@dianqk dianqk commented Sep 3, 2023

Fixes #65195.

LVI information may be out of date after combineMetadataForCSE.

@dianqk dianqk requested a review from a team as a code owner September 3, 2023 06:26
@dianqk dianqk requested a review from nikic September 3, 2023 06:27
@dianqk dianqk force-pushed the jump-threading-invalidate-lvi branch from 1eca78a to c91532e Compare September 3, 2023 10:12
@dianqk dianqk requested a review from a team as a code owner September 3, 2023 10:12
@dianqk dianqk force-pushed the jump-threading-invalidate-lvi branch 4 times, most recently from 1674639 to 8cd3953 Compare September 3, 2023 14:23
@dianqk dianqk force-pushed the jump-threading-invalidate-lvi branch from 8cd3953 to edf78ec Compare September 3, 2023 23:59
Copy link
Contributor

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dianqk
Copy link
Member Author

dianqk commented Sep 4, 2023

If I use "Squash and merge", it may cause the cherry-pick of the backport to fail?
So I should use fast-forward merge with local rebase?

@dianqk dianqk force-pushed the jump-threading-invalidate-lvi branch from edf78ec to 7af408e Compare September 4, 2023 03:50
@dianqk dianqk merged commit 7af408e into llvm:main Sep 4, 2023
@dianqk dianqk deleted the jump-threading-invalidate-lvi branch September 4, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JumpThreading error removes call void @bar() instruction.
2 participants