Skip to content

Added github action to update feature catalog MD file #1714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 9, 2025
Merged

Added github action to update feature catalog MD file #1714

merged 7 commits into from
Apr 9, 2025
+183 −0

Conversation

k-a-il
Copy link
Contributor

@k-a-il k-a-il commented Mar 28, 2025 •
edited
Loading

This PR adds a GitHub Action to generate a feature catalog Markdown file, used here. The file is created based on features.yml artifacts downloaded from the localstack/localstack and localstack/localstack-ext repositories.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 28, 2025 •
edited
Loading

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-1714.surge.sh 🎊

@k-a-il k-a-il self-assigned this Mar 28, 2025
@k-a-il k-a-il requested a review from sannya-singal April 3, 2025 10:41
@k-a-il k-a-il marked this pull request as ready for review April 3, 2025 10:41
@k-a-il k-a-il changed the title Added github action to update feature catalog file Added github action to update feature catalog MD file Apr 3, 2025
@quetzalliwrites quetzalliwrites self-requested a review April 3, 2025 22:28
sannya-singal
sannya-singal reviewed Apr 4, 2025
View reviewed changes
Copy link
Contributor

@sannya-singal sannya-singal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions and comments, otherwise LGTM 🎉

@k-a-il k-a-il requested a review from sannya-singal April 8, 2025 11:01
sannya-singal
sannya-singal approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@sannya-singal sannya-singal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 Thanks for working on the review comments 🎉

From what I was looking for in https://github.com/localstack/docs/pull/1714/files#r2028301494 was a sample MD file generated from the feature coverage yml files but the description of the PR redirects me to the current localstack feature coverage page: https://docs.localstack.cloud/user-guide/aws/feature-coverage/.

@k-a-il
Copy link
Contributor Author

k-a-il commented Apr 9, 2025

From what I was looking for in https://github.com/localstack/docs/pull/1714/files#r2028301494 was a sample MD file generated from the feature coverage yml files but the description of the PR redirects me to the current localstack feature coverage page: https://docs.localstack.cloud/user-guide/aws/feature-coverage/.

Indeed, sorry, I've added the document to the task description instead of PR.

@k-a-il k-a-il merged commit 7e14ca0 into main Apr 9, 2025
4 checks passed
@k-a-il k-a-il deleted the feature-catalog-prototype branch April 9, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sannya-singal sannya-singal sannya-singal approved these changes

@quetzalliwrites quetzalliwrites Awaiting requested review from quetzalliwrites

Assignees

@k-a-il k-a-il

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-a-il @sannya-singal