-
Notifications
You must be signed in to change notification settings - Fork 599
[rtl] Add common security features of regfiles to separate module #2266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
7f7f613
to
8466e42
Compare
can someone with access to the private ci let me know what the fails are? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your interest in the Ibex repository. In its current state this PR is a bit hard to review. First, please avoid making lots of white space changes. And if you do want to make a whole load of white space changes please separate them from the commits that have functional changes. Would you mind adding a comment in the common register file to say what functionality you've pulled out. And it would also be nice if you could put a short description in the pull request itself to describe what you've done and how what you've done still has the same functionality as before.
2d1bb01
to
2d0414f
Compare
I've tried resolving all the whitespace changes I had introduced unintentionally @marnovandermaas
#2217 was opened to bring together common logic present in each of the three regfile implementations into one common module which can then be instantiated in each of the three implementations. This PR mainly combines the security hardening logic that checks for onehot encoding in various signals for glitches in addresses and write enable(s). It tries to maintain the same logic as before wrt parameterization of these checks. |
2d0414f
to
e3db76b
Compare
e3db76b
to
c4a9389
Compare
Resolves #2217