This repository was archived by the owner on Jun 7, 2022. It is now read-only.
Python3 conversion #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2to3 with some manual cleanup
Basically you are supposed to use __new__ instead of __init__ or some such, just "don't derive from namedtuple" is easier, even if this means losing immutability for `output` parameter.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi I was wondering if you have plans to move over to Python3 for this project?
In Ubuntu 18.04 default python is now 3, so I thought I'll try converting this to 3 as well. It seems to work fine.
This is mostly automatic conversion using
2to3with some extra edits on top of that. The only weird problem was with inheritance fromnamedtuple, basicallyA->namedtupleworks fine, butB->A->namedtupleis somehow broken. Rather than figuring it out, I just madeAptRequestderive fromobjectand setoutputmember manually.Just thought I'll share this via pull request, feel free to reject this if you need to stay in python2 for a while.