Skip to content

Add workflow_call support in unittests workflow #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 9, 2025

Conversation

JSabadin
Copy link
Contributor

@JSabadin JSabadin commented May 7, 2025

Purpose

PR Description:

  • Introduce workflow_call with ml_ref and tools_ref inputs
  • Checkout tools at specified ref when invoked externally
  • Install the target luxonis-ml version via ml_ref
  • Preserve existing behavior for PR-triggered runs
  • Enables BOM tests on external repos to validate integration in tools

Specification

None / not applicable

Dependencies & Potential Impact

None / not applicable

Deployment Plan

None / not applicable

Testing & Validation

None / not applicable

@JSabadin JSabadin requested review from klemen1999 and jkbmrz May 7, 2025 15:26
Copy link

github-actions bot commented May 7, 2025

Test Results

  6 files    6 suites   8m 11s ⏱️
 24 tests  24 ✅ 0 💤 0 ❌
144 runs  144 ✅ 0 💤 0 ❌

Results for commit a81def9.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 8, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
22182 4819 22% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: a81def9 by action🐍

Copy link
Contributor

@jkbmrz jkbmrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise but I lack some context/purpose of why the changes (i.e. external calls to the workflow) are needed.

Copy link
Collaborator

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@jkbmrz : Context is BOM testing so we can check that every new luxonis-ml release is compatible with all other repos

@JSabadin JSabadin changed the title Add workflow_call support in unittests workflow Add workflow_call support in unittests workflow May 8, 2025
@JSabadin JSabadin merged commit a6b3818 into main May 9, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants