-
Notifications
You must be signed in to change notification settings - Fork 122
scaffolding: add templates and functionality for backend scaffolding #3263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This PR has been marked as stale after 7 or more days of inactivity. Please have a maintainer add the |
This PR has been marked as stale after 7 or more days of inactivity. Please have a maintainer add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- Makefile: Language not supported
} | ||
break | ||
} else if strings.Contains(line, "gateway.Run(") { | ||
*lines = slices.Insert(*lines, i, registrationLine, "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The slices.Insert function is called with an extra argument; the standard library version expects only one element to insert. Consider removing the extra "" argument so that the function call matches the expected signature.
*lines = slices.Insert(*lines, i, registrationLine, "") | |
*lines = slices.Insert(*lines, i, registrationLine) |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
if r == nil || len(matches) != 4 { | ||
log.Fatal(fmt.Errorf("unable to determine git upstream from %s", urlStr)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The check is using 'r == nil' instead of verifying if 'matches' is nil. Update the condition to 'if matches == nil || len(matches) != 4' to correctly validate the regex output.
if r == nil || len(matches) != 4 { | |
log.Fatal(fmt.Errorf("unable to determine git upstream from %s", urlStr)) | |
if matches == nil || len(matches) != 4 { |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Description
Testing Performed
Manual testing
make scaffold-service
make scaffold-api
GitHub Issue
TODOs