Make getDataProvider to reduce export duplicate code #39966
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This PR makes getDataProvider on the massaction public.
Why do we want this? To reduce unnecessary duplicate code. In the updated files you can see i've been able to remove
prepareComponent
.This is because
getDataProvider
literally calls that when called and no dataProvider has been cached yet.The call under there
applySelectionOnTargetProvider
actually callsgetDataProvider
as well. This means before this PRprepareComponent
was always called twice during an export. Simply because we couldn't callgetDataProvider
and be sureprepareComponent
was called.Manual testing scenarios (*)
Contribution checklist (*)