magento/magento2#39948: Magento_Persistent performance overhead on non-cart, non-checkout pages

[KrasnoshchokBohdan]

• new QuoteResourceWrapper class that uses direct SQL queries instead of loading the entire quote object, which should improve performance

Description (*)

I decided to test the solution proposed by the author. It turned out that the changes reduced the execution time of CheckExpirePersistentQuoteObserver from ~52ms to less than 1ms.
Before

After

So I make this pull request to initiate further discussion.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Magento_Persistent performance overhead on non-cart, non-checkout pages #39948

Manual testing scenarios (*)

1. Add product to cart (for example from PLP)
2. Enter PDP with profiler enabled

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @KrasnoshchokBohdan. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[KrasnoshchokBohdan]

@magento run all tests

[Copilot]

Pull Request Overview

This pull request aims to improve performance of the persistent quote handling by introducing a new QuoteResourceWrapper that leverages direct SQL queries to check quote persistence and activeness without loading the entire quote object. The key changes include:

• Adding a new QuoteResourceWrapper class to directly query quote attributes.
• Updating CheckExpirePersistentQuoteObserver to use QuoteResourceWrapper for persistence and activeness checks.
• Replacing the full-quote validation with lightweight SQL queries to reduce execution time.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
app/code/Magento/Persistent/Observer/CheckExpirePersistentQuoteObserver.php	Observer now uses QuoteResourceWrapper and replaces getQuote() checks with direct SQL query lookups.
app/code/Magento/Persistent/Model/QuoteResourceWrapper.php	New class introduced to encapsulate SQL queries for quote status checks.

Comments suppressed due to low confidence (1)

app/code/Magento/Persistent/Observer/CheckExpirePersistentQuoteObserver.php:127

• Directly using ObjectManager as a fallback in the constructor can be considered a violation of dependency injection best practices. Consider ensuring QuoteResourceWrapper is always provided via DI configuration (e.g., in di.xml) rather than falling back to ObjectManager.

$this->quoteResourceWrapper = $quoteResourceWrapper ?: ObjectManager::getInstance()->get(QuoteResourceWrapper::class);

[KrasnoshchokBohdan]

@magento run all tests

[KrasnoshchokBohdan]

@magento run Static Tests

[KrasnoshchokBohdan]

@magento run Database Compare, Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Magento Health Index, Sample Data Tests B2B, Sample Data Tests CE, Sample Data Tests EE, Semantic Version Checker, Unit Tests, WebAPI Tests