-
Notifications
You must be signed in to change notification settings - Fork 658
feat: code-comparison line-highlight #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
itsarghyadas
commented
Feb 14, 2025
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fixes #533 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need code cleanup
registry/magicui/code-comparison.tsx
Outdated
if (highlightedBefore || highlightedAfter) { | ||
const hasBeforeFocus = highlightedBefore.includes('class="line focused"'); | ||
const hasAfterFocus = highlightedAfter.includes('class="line focused"'); | ||
console.log( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should remove these
registry/magicui/code-comparison.tsx
Outdated
"--highlight-color": highlightColor, | ||
} as React.CSSProperties | ||
} | ||
/* [&>pre]:!w-full [&>pre]:p-4 */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
// diff | ||
|
||
// add | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
cc45683
to
5a77511
Compare