Skip to content

feat: code-comparison line-highlight #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 24, 2025

Conversation

itsarghyadas
Copy link
Collaborator

image

Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
magicui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 6:26pm

@dillionverma
Copy link
Collaborator

fixes #533

Copy link
Collaborator

@dillionverma dillionverma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need code cleanup

if (highlightedBefore || highlightedAfter) {
const hasBeforeFocus = highlightedBefore.includes('class="line focused"');
const hasAfterFocus = highlightedAfter.includes('class="line focused"');
console.log(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should remove these

"--highlight-color": highlightColor,
} as React.CSSProperties
}
/* [&>pre]:!w-full [&>pre]:p-4 */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

// diff

// add

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@dillionverma dillionverma force-pushed the code-comparison-line-highlight branch from cc45683 to 5a77511 Compare March 24, 2025 18:23
@dillionverma dillionverma merged commit c81f17d into main Mar 24, 2025
5 checks passed
@dillionverma dillionverma deleted the code-comparison-line-highlight branch March 24, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants