chore: Add workspace slug to should render setting link method #6886
Conversation
WalkthroughThe changes update the invocation and signature of the Changes
Sequence Diagram(s)sequenceDiagram
participant UI as User Interface
participant SL as shouldRenderSettingLink
UI->>SL: Call with (workspaceSlug.toString(), key)
SL-->>UI: Return boolean value
alt true
UI->>UI: Render setting link
else false
UI->>UI: Do not render link
end
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
web/app/[workspaceSlug]/(projects)/settings/(with-sidebar)/mobile-header-tabs.tsx(1 hunks)web/app/[workspaceSlug]/(projects)/settings/(with-sidebar)/sidebar.tsx(1 hunks)web/ce/helpers/workspace.helper.ts(1 hunks)web/core/components/command-palette/actions/workspace-settings-actions.tsx(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (3)
web/app/[workspaceSlug]/(projects)/settings/(with-sidebar)/sidebar.tsx (2)
web/ce/helpers/workspace.helper.ts (1)
shouldRenderSettingLink(2-2)web/core/store/router.store.ts (1)
workspaceSlug(69-71)
web/app/[workspaceSlug]/(projects)/settings/(with-sidebar)/mobile-header-tabs.tsx (2)
web/ce/helpers/workspace.helper.ts (1)
shouldRenderSettingLink(2-2)web/core/store/router.store.ts (1)
workspaceSlug(69-71)
web/ce/helpers/workspace.helper.ts (1)
web/core/store/router.store.ts (1)
workspaceSlug(69-71)
🔇 Additional comments (3)
web/app/[workspaceSlug]/(projects)/settings/(with-sidebar)/mobile-header-tabs.tsx (1)
23-23: Updated function call to include the workspace slugThe function call now correctly includes
workspaceSlug.toString()as the first parameter to match the updated function signature inworkspace.helper.ts. This allows the rendering logic to consider the workspace context.web/app/[workspaceSlug]/(projects)/settings/(with-sidebar)/sidebar.tsx (1)
31-31: Updated function call to include the workspace slugThe function call now correctly includes
workspaceSlug.toString()as the first parameter to match the updated function signature inworkspace.helper.ts. This allows the rendering logic to consider the workspace context.web/core/components/command-palette/actions/workspace-settings-actions.tsx (1)
43-43: Updated function call to include the workspace slugThe function call now correctly includes
workspaceSlug.toString()as the first parameter to match the updated function signature inworkspace.helper.ts. This allows the rendering logic to consider the workspace context.
| export type TRenderSettingsLink = (workspaceSlug: string, settingKey: string) => boolean; | ||
| export const shouldRenderSettingLink: TRenderSettingsLink = () => true; |
There was a problem hiding this comment.
Function signature doesn't match implementation
You've correctly added the type definition and updated the function signature, but there's a mismatch between the type signature and implementation. The type indicates two parameters (workspaceSlug and settingKey), but the implementation doesn't accept any parameters.
Apply this diff to fix the implementation:
export type TRenderSettingsLink = (workspaceSlug: string, settingKey: string) => boolean;
-export const shouldRenderSettingLink: TRenderSettingsLink = () => true;
+export const shouldRenderSettingLink: TRenderSettingsLink = (workspaceSlug, settingKey) => true;While the function currently always returns true regardless of parameters, having the correct parameter names in the implementation will make it clearer and easier to modify in the future when you might need to use these parameters for conditional logic.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| export type TRenderSettingsLink = (workspaceSlug: string, settingKey: string) => boolean; | |
| export const shouldRenderSettingLink: TRenderSettingsLink = () => true; | |
| export type TRenderSettingsLink = (workspaceSlug: string, settingKey: string) => boolean; | |
| export const shouldRenderSettingLink: TRenderSettingsLink = (workspaceSlug, settingKey) => true; |
Description
Add workspace slug to should render setting link method
Type of Change
Screenshots and Media (if applicable)
Test Scenarios
References
Summary by CodeRabbit