Skip to content

Don't return Weak dependencies in updates #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2021
Merged

Conversation

timlau
Copy link
Collaborator

@timlau timlau commented Jun 14, 2021

weak dependencies is currently shown when getting updates, this gives errors when trying to add them to the transaction

g-io-error-quark: GDBus.Error:org.freedesktop.DBus.Python.dnf.exceptions.MarkingError: Traceback (most recent call last):
  File "/usr/lib64/python3.9/site-packages/dbus/service.py", line 711, in _message_cb
    retval = candidate_method(self, *args, **keywords)
  File "/usr/lib/python3.9/site-packages/dnfdaemon/server/__init__.py", line 68, in newFunc
    rc = func(*args, **kwargs)
  File "/usr/share/dnfdaemon/dnfdaemon-system", line 488, in AddTransaction
    value = self.add_transaction(pkg_id, action)
  File "/usr/lib/python3.9/site-packages/dnfdaemon/server/__init__.py", line 566, in add_transaction
    rc = self.base.package_upgrade(po)
  File "/usr/lib/python3.9/site-packages/dnf/base.py", line 2074, in package_upgrade
    raise dnf.exceptions.MarkingError(
dnf.exceptions.MarkingError: No match for argument: Packages/f/fedora-packager-kerberos-0.6.0.6-2.fc34.noarch.rpm: fedora-packager-kerberos
 (36)

@Conan-Kudo
Copy link
Member

@timlau I think @papoteur-mga is trying to add support for weak deps in #45, does that help for your case?

@timlau
Copy link
Collaborator Author

timlau commented Jun 14, 2021

Nope, He is working on returning weak dependencies in the transaction result

My PR is to fix an error, when return GetPackages('updates') that should return only updates & installonly packages like kernel and not weak dependencies.
When we are executing the transaction, then weak dependencies is pulled in and #45 will make it possible to show these packages as weak depencies and not just like packages being installed.

@timlau
Copy link
Collaborator Author

timlau commented Jun 16, 2021

found another case to error. updates with new dependencies, will have these list when getting a list of updates, but give a marking error when they are added to transaction because they are not direct updates and don't update anything.

The changes will not break anything, it will only remove packages there are not reel updates for the list of available updates. returned by GetPackages('updates').

The dependencies will be pulled in when we do the transactions, as they are supposed to do,

@timlau
Copy link
Collaborator Author

timlau commented Jun 16, 2021

Looks like PyCharm as fixed some wrong indentation in the file also, there is include in the patch also

@anaselli
Copy link
Contributor

@timlau @Conan-Kudo if you both agreed we can add @timlau back to push rights. Maybe just opening an issue against dnfdragora when something pushed could break compatibility.

@Conan-Kudo
Copy link
Member

Fine with me.

@timlau timlau merged commit 17a99b1 into manatools:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants