Skip to content

Add publishing action #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2025
Merged

Add publishing action #1274

merged 3 commits into from
Jun 16, 2025

Conversation

zorkow
Copy link
Member

@zorkow zorkow commented Jun 6, 2025

This PR

  • adds a publishing action
  • renames the test action from test.js.yml to test.yml as the js bit does not make any sense!

I have tested the publishing action for the build. I need an npm authentication token for the final step.

@zorkow zorkow requested a review from dpvc June 6, 2025 16:55
Copy link
Member

@dpvc dpvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the .travis.yaml file be removed with this PR? I'm not sure how that is hooked in. I think there is a setting that should be removed for the repository as well.

I also was wondering about whether the tests need to be run here, but I guess if they are run on all the PRs, they don't have to be done here.

Base automatically changed from fix/eslint_package to develop June 13, 2025 09:38
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.68%. Comparing base (c58d95f) to head (a890bdf).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #1274     +/-   ##
==========================================
  Coverage    86.68%   86.68%             
==========================================
  Files          337      337             
  Lines        84105    84105             
  Branches      3125     4750   +1625     
==========================================
  Hits         72909    72909             
  Misses       11196    11196             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member Author

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done the changes and it runs locally with act. Yet to be tested is the publish job.

@zorkow
Copy link
Member Author

zorkow commented Jun 15, 2025

Should the .travis.yaml file be removed with this PR? I'm not sure how that is hooked in. I think there is a setting that should be removed for the repository as well.

I had forgotten to remove the .travis.yaml file, but that's gone now.

I also was wondering about whether the tests need to be run here, but I guess if they are run on all the PRs, they don't have to be done here.

Tests will run for every PR to develop branch, regardless whether or not test relevant files have changed. I have never worked out to restrict this to say "only changes in the ts directory". But I am also not sure if it is worth it, because you still want tests running when changing things like packages in package.json or changes in the components directory, etc.

Copy link
Member

@dpvc dpvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zorkow zorkow merged commit 351698e into develop Jun 16, 2025
3 checks passed
@zorkow zorkow deleted the feature/publish_action branch June 16, 2025 16:54
@dpvc dpvc added this to the v4.0 milestone Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants