-
Notifications
You must be signed in to change notification settings - Fork 221
Add publishing action #1274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add publishing action #1274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the .travis.yaml
file be removed with this PR? I'm not sure how that is hooked in. I think there is a setting that should be removed for the repository as well.
I also was wondering about whether the tests need to be run here, but I guess if they are run on all the PRs, they don't have to be done here.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1274 +/- ##
==========================================
Coverage 86.68% 86.68%
==========================================
Files 337 337
Lines 84105 84105
Branches 3125 4750 +1625
==========================================
Hits 72909 72909
Misses 11196 11196 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done the changes and it runs locally with act
. Yet to be tested is the publish
job.
I had forgotten to remove the
Tests will run for every PR to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR
test.js.yml
totest.yml
as thejs
bit does not make any sense!I have tested the publishing action for the build. I need an
npm
authentication token for the final step.