Skip to content

Staging #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Staging #29

wants to merge 28 commits into from

Conversation

EUdler
Copy link
Collaborator

@EUdler EUdler commented Feb 6, 2025

  • Routine changes for R2025a
  • Fixed image source file for each release readme
  • Changes for when using an existing vNet

@EUdler EUdler requested review from mwshriya and mahimab1 February 6, 2025 20:42
@mahimab1
Copy link
Member

mahimab1 commented Feb 7, 2025

Looks good to me!

Copy link
Member

@mahimab1 mahimab1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add somewhere private end point description to access the storage account? Like in case when usePublicIPAddress is set to "No", then the storage account is only accessible via private end point. The user can create a jumper VM in the same VNet -> subnet to access it. It is more likely an Azure workflow not anything specific to us and I guess the user will know if they see private end point with storage account but I guess it might be important for the user to know before hand so that they don't have to navigate and understand. @mwshriya @EUdler Let me know your opinion

Added information about private endpoint as Mahima suggested
@EUdler EUdler requested a review from mahimab1 February 12, 2025 20:49
Copy link
Member

@mahimab1 mahimab1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the feedback. Looks good now!

In the "Allow Connections From" field, I added an example of the format for listing multiple addresses
Made changes based on Shriya's feedback
-Added to "Use Public IP Addresses" field to add info about storage account
-Added information about NLM and function execution to "Allow Connections From" field
Added release notes for 2025a
Reorganized information in readme
Reorganize content - move info about existing VN to FAQ
Copy link
Member

@mahimab1 mahimab1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But, need to verify/resolve Health check test

- The **Assign Public IP Address to VM Hosting MATLAB Production Server** entry of the deployment template now controls access to the storage account. For details, see the **Assign Public IP Address to VM Hosting MATLAB Production Server** entry in the [Configure Cloud Resources](/releases/R2025a/README.md#step-2-configure-cloud-resources) step of the deployment process.
- If you assign a public IP address to the VM hosting MATLAB Production Server, then public network access to the storage account is enabled only from selected virtual networks and IP addresses. Previously, public network access was enabled from all networks.
- If you assign a private IP address to the VM hosting MATLAB Production Server, then public network access to the storage account is disabled. You must use a bastion host or jump box VM to connect to the storage account. Previously, storage account access was enabled from all networks.
- If you deploy using an existing virtual network, you must manually add a private or service endpoint to the virtual network before deploying MATLAB Production Server in order to create and access the storage account. For details, see [Create Endpoint in Virtual Network](/releases/R2025a/README.md#create-endpoint-in-virtual-network).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you never need to add a private endpoint. @mahimab1, please confirm. If that is indeed the case, this line would need updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants