feat(thread): compute a thread summary whenever we receive new events #5042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(put back to draft state, as it was intended to be, but I forgot to click the button before opening the PR.) |
bnjbvr
commented
May 14, 2025
| // If there's a bundled relation, but it's not a thread, we can still extract | ||
| // without failing. | ||
| let mut relations = BundledMessageLikeRelations::new(); | ||
| relations.replace = Some(Box::new(f.text_msg("hello wrold!").into_raw())); |
There was a problem hiding this comment.
hah, it was supposed to be the replacement event for a message that had a typo in it, but of course the typos bot is unhappy with such a test setup krkrkr
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5042 +/- ##
=======================================
Coverage 85.80% 85.81%
=======================================
Files 332 334 +2
Lines 36195 36276 +81
=======================================
+ Hits 31056 31129 +73
- Misses 5139 5147 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bnjbvr
force-pushed
the
bnjbvr/basic-thread-summary
branch
2 times, most recently
from
b2012ba to
38b43f0
Compare
…d the room are set
This is our own variant of the Ruma `BundledThread`, but with more information that might be relevant to us, and that we can add over time.
bnjbvr
force-pushed
the
bnjbvr/basic-thread-summary
branch
from
38b43f0 to
47b73c7
Compare
bnjbvr
force-pushed
the
bnjbvr/basic-thread-summary
branch
from
47b73c7 to
9610a1d
Compare
|
Superseded by #5126, which this PR has been split up into, and rejiggered a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also contains the minimal scaffolding for storing thread information in a room.
More to come soon:
Part of #5036 (#4869).