Skip to content

feat: cumulative update: library linking, recursion fix, a lot of tests #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 29, 2024

Conversation

hedgar2017
Copy link
Collaborator

@hedgar2017 hedgar2017 commented Oct 25, 2024

What ❔

  1. Fixes the extra_metadata serialization.
  2. Fixes indeterminism with library linking.
  3. Adds tests for solc child process errors.
  4. Adds tests for a lot of corner use cases of input.
  5. Simplifies [de]seriailizeable data structures even more.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via cargo fmt and checked with cargo clippy.

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 84.90854% with 99 lines in your changes missing coverage. Please review.

Project coverage is 60.67%. Comparing base (49d5c16) to head (bb7cd71).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
era-compiler-solidity/src/zksolc/main.rs 71.23% 63 Missing ⚠️
era-compiler-solidity/src/lib.rs 65.00% 28 Missing ⚠️
era-compiler-solidity/src/build_evm/mod.rs 0.00% 4 Missing ⚠️
era-compiler-solidity/src/project/mod.rs 94.28% 2 Missing ⚠️
era-compiler-solidity/src/build_evm/contract.rs 0.00% 1 Missing ⚠️
...a-compiler-solidity/src/project/contract/ir/yul.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
+ Coverage   58.30%   60.67%   +2.37%     
==========================================
  Files         128      129       +1     
  Lines       15567    15397     -170     
==========================================
+ Hits         9076     9342     +266     
+ Misses       6491     6055     -436     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hedgar2017 hedgar2017 force-pushed the az-tests-for-solc-errors branch 8 times, most recently from 3f10e64 to 27e6df8 Compare October 26, 2024 15:25
@hedgar2017
Copy link
Collaborator Author

Hey @antonbaliasnikov, it looks like we need to install Rosetta to fix these errors: https://github.com/matter-labs/era-compiler-solidity/actions/runs/11532927790/job/32105256038?pr=183
Is it possible on that runner?

@hedgar2017 hedgar2017 force-pushed the az-tests-for-solc-errors branch 2 times, most recently from 0adf3a1 to f9ed928 Compare October 27, 2024 18:53
@antonbaliasnikov
Copy link
Contributor

Hey @antonbaliasnikov, it looks like we need to install Rosetta to fix these errors: https://github.com/matter-labs/era-compiler-solidity/actions/runs/11532927790/job/32105256038?pr=183 Is it possible on that runner?

Hey @hedgar2017 ,

I've installed Rosetta and tested it, please, try to re-run Macos and let me know if it's still not working.

@hedgar2017 hedgar2017 force-pushed the az-tests-for-solc-errors branch 3 times, most recently from 23459ac to 0435f6c Compare October 29, 2024 04:09
@hedgar2017 hedgar2017 marked this pull request as ready for review October 29, 2024 04:10
@hedgar2017 hedgar2017 force-pushed the az-tests-for-solc-errors branch from 0435f6c to b5f3018 Compare October 29, 2024 04:11
@hedgar2017
Copy link
Collaborator Author

Hey @antonbaliasnikov, my bash scripts don't work on Windows as I expected :(
Do you know how to fix? Perhaps, something is off with the shebang line?

@hedgar2017 hedgar2017 force-pushed the az-tests-for-solc-errors branch from 9335e87 to 98a7ce2 Compare October 29, 2024 04:36
@hedgar2017 hedgar2017 changed the title fix: the extra_metadata serialization feat: cumulative update: library linking, recursion fix, a lot of tests Oct 29, 2024
@antonbaliasnikov
Copy link
Contributor

Hey @antonbaliasnikov, my bash scripts don't work on Windows as I expected :( Do you know how to fix? Perhaps, something is off with the shebang line?

Hey, I'm taking a look on that.

@antonbaliasnikov
Copy link
Contributor

Hey @antonbaliasnikov, my bash scripts don't work on Windows as I expected :( Do you know how to fix? Perhaps, something is off with the shebang line?

Hey, I'm taking a look on that.

@hedgar2017 , this should fix the problem #186

Copy link
Contributor

@antonbaliasnikov antonbaliasnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is quite huge to review thoroughly, but LGTM.

@hedgar2017 hedgar2017 merged commit 3e25eac into main Oct 29, 2024
14 checks passed
@hedgar2017 hedgar2017 deleted the az-tests-for-solc-errors branch October 29, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants