-
Notifications
You must be signed in to change notification settings - Fork 34
feat: cumulative update: library linking, recursion fix, a lot of tests #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
==========================================
+ Coverage 58.30% 60.67% +2.37%
==========================================
Files 128 129 +1
Lines 15567 15397 -170
==========================================
+ Hits 9076 9342 +266
+ Misses 6491 6055 -436 ☔ View full report in Codecov by Sentry. |
3f10e64
to
27e6df8
Compare
Hey @antonbaliasnikov, it looks like we need to install Rosetta to fix these errors: https://github.com/matter-labs/era-compiler-solidity/actions/runs/11532927790/job/32105256038?pr=183 |
0adf3a1
to
f9ed928
Compare
Hey @hedgar2017 , I've installed Rosetta and tested it, please, try to re-run Macos and let me know if it's still not working. |
23459ac
to
0435f6c
Compare
0435f6c
to
b5f3018
Compare
Hey @antonbaliasnikov, my bash scripts don't work on Windows as I expected :( |
9335e87
to
98a7ce2
Compare
Hey, I'm taking a look on that. |
@hedgar2017 , this should fix the problem #186 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR is quite huge to review thoroughly, but LGTM.
What ❔
extra_metadata
serialization.Checklist
cargo fmt
and checked withcargo clippy
.