Skip to content

Document the project policy on mixing build systems. [skip ci] #6603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

jpakkane
Copy link
Member

@jpakkane jpakkane commented Feb 9, 2020

No description provided.

or that they are built as Meson subprojects under the main
project. There are several projects that would like to mix build
systems, that is, build dependencies in the same build directory in
the same build directory by having one build system call the other.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"in the same build directory in the same build directory" (duplicated)

work), and even if it works today there are no guarantees that it will
keep working in any future version.

## The definition of "buils system mixing"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo ("buils")

@xclaesse
Copy link
Member

I'm not sure if this means cargo module as proposed in #2617 would be accepted or not.

@nirbheek
Copy link
Member

I'm not sure if this means cargo module as proposed in #2617 would be accepted or not.

I would interpret this as meaning "go ahead and merge it", because it meets all these requirements.

project. There are several projects that would like to mix build
systems, that is, build dependencies in the same build directory as
the other build system by having one build system call the other. The
build diectories do not necessarily need to be inside each other, but
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*build directories

tl/dr version is that while we do provide some functionality for this
use case, it only works for simple cases. Anything more complex can
not be made reliable and trying to do that would burden Meson
developers with an effectively infinite maintenance burder. Thus these
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*burden

build diectories do not necessarily need to be inside each other, but
that is the common case.

This page lists the Meson project's stance on mixing build system. The
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*build systems

@jpakkane
Copy link
Member Author

The point of this PR was to make it possible to merge things like #2617. It does not mean that they will be automatically and blindly merged, though. They must be reviewed as usual and in addition every piece of functionality (mostly modules) that falls under this rule must start its documentation by referring to this guide (like the CMake module does in this commit).

@jpakkane jpakkane merged commit 999376a into master Feb 25, 2020
@jpakkane jpakkane deleted the mixbuildsystems branch February 25, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants