Improve readability of PixelShuffle operation in Llama4 #304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the readability of the
pixel_shuffle_op()
function within llama_models/llama4/vision/embedding.py.Previously, the input tensor dimensions were unpacked as$[N, H, W, C]$ , this PR aligns the naming accordingly.
n, w, h, c = input_x.size()
, but since the tensor dimensions withinPixelShuffle.forward()
are expected to beSince the implementation assumes a square patch input, this change does not affect the underlying logic and is strictly for readability enhancement.
Additionally, the type annotation for ps_ratio has been added because it differs slightly from
torch.nn.PixelShuffle
by accepting afloat
.