Skip to content

fix: React Agent for non-llama models #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2025
Merged

fix: React Agent for non-llama models #174

merged 2 commits into from
Feb 28, 2025

Conversation

hardikjshah
Copy link
Contributor

  • Cannot take Any in structured outputs for ReActOutput ( updated the structure )
  • open-ai takes "string" instead of "str" in tool param
  • better error handling in event logger

@hardikjshah hardikjshah changed the title Fix React Agent for non-llama models fix: React Agent for non-llama models Feb 28, 2025
@yanxi0830
Copy link
Contributor

run a pre-commit?

@hardikjshah hardikjshah merged commit ee5dd2b into main Feb 28, 2025
2 checks passed
@hardikjshah hardikjshah deleted the react_fix branch February 28, 2025 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanxi0830 yanxi0830 yanxi0830 approved these changes

@ashwinb ashwinb Awaiting requested review from ashwinb ashwinb is a code owner

@dltn dltn Awaiting requested review from dltn dltn is a code owner

@raghotham raghotham Awaiting requested review from raghotham raghotham is a code owner

@dineshyv dineshyv Awaiting requested review from dineshyv dineshyv is a code owner

@vladimirivic vladimirivic Awaiting requested review from vladimirivic vladimirivic is a code owner

@ehhuang ehhuang Awaiting requested review from ehhuang ehhuang is a code owner

@SLR722 SLR722 Awaiting requested review from SLR722 SLR722 is a code owner

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hardikjshah @yanxi0830 @facebook-github-bot