fix: update getting started guide to use ollama pull
#1855
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattf
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn,
raghotham,
dineshyv,
vladimirivic,
sixianyi0721,
ehhuang,
terrytangyuan,
SLR722 and
leseb
as code owners
facebook-github-bot
added
the
CLA Signed
|
@raghotham @leseb ptal |
mattf
changed the title
ollama pullollama pull
booxter
approved these changes
Apr 2, 2025
|
@ashwinb @raghotham afaict the docs aren't versioned. i recommend only publishing this change after a release w/ #1854 is cut. |
franciscojavierarceo
approved these changes
Apr 4, 2025
|
@mattf please rebase and resolve the conflicts :) Thanks! |
leseb
requested changes
Apr 7, 2025
leseb
approved these changes
Apr 9, 2025
|
This PR made the model names inconsistent - llama3.2:3b-instruct-fp16 vs llama3.2:3b. This broke the tutorial. Also, we should stop pushing docs automatically to readthedocs. This change is now live. |
Good catch, here is a fix #1926 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
download the getting started w/ ollama model instead of downloading and running it.
directly running it was necessary before #1854
Test Plan
run the code on the page