-
Notifications
You must be signed in to change notification settings - Fork 974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update integration test workflow #1856
base: main
Are you sure you want to change the base?
Conversation
workflow - 0. Checkout 1. Install uv 2. Install Ollama 3. Pull Ollama image 4. Start Ollama in background 5. Set Up Environment and Install Dependencies 6. Wait for Ollama to start 7. Start Llama Stack server in background 8. Wait for Llama Stack server to be ready 9. Run Integration Tests changes - (4) starts the loading of the ollama model, it does not start ollama. the model will be loaded when used. this step is removed. (6) is handled in (2). this step is removed. (2) is renamed to reflect it's dual purpose.
@leseb ptal |
the integration tests will pass once #1854 is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind adding this in #1854? So we can validate both at the same time? Thanks!
my preference is small, contained changes. this request can be independently rejected if it's not desired. it is not critical for proper functioning. the other change is important for properly working functionality. i can merge them if you want. |
Small contained changes can be achieved by commits, not always PRs.
Given that you remove "ollama run" from the CI I was under the impression that this could help validate #1854 behavior. Did I miss something? |
the existing workflow (without this PR) will also validate #1854, since a run does a pull. |
Yes, but isn't the goal to just do a "pull" and let ollama do the "run" when a request comes in? |
workflow -
0. Checkout
changes -
(4) starts the loading of the ollama model, it does not start ollama. the model will be loaded when used. this step is removed.
(6) is handled in (2). this step is removed.
(2) is renamed to reflect it's dual purpose.