Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: colorize Discord badge & add icon in README #1865

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wescpy
Copy link

@wescpy wescpy commented Apr 3, 2025

Update "chat" badge on README to make it more visible for visitors; changing the look from

image

... to ...

image

@facebook-github-bot
Copy link

Hi @wescpy!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link
Collaborator

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to keep these in one line? Otherwise on mobile it looks like this image

@terrytangyuan
Copy link
Collaborator

Please sign the individual CLA for now

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 3, 2025
@wescpy
Copy link
Author

wescpy commented Apr 3, 2025

FIXED & SIGNED

@wescpy wescpy requested a review from terrytangyuan April 3, 2025 00:56
@terrytangyuan
Copy link
Collaborator

Thanks!

Copy link
Collaborator

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were told to hold off on merging anything for the rest of the week (requested from Meta). Will merge next week.

@wescpy
Copy link
Author

wescpy commented Apr 3, 2025

SGTM (sounds good to me)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants