feat: Updated playground rag to use session id for persistent conversation #1870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelClifford
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn,
raghotham,
dineshyv,
vladimirivic,
sixianyi0721,
ehhuang,
terrytangyuan,
SLR722 and
leseb
as code owners
facebook-github-bot
added
the
CLA Signed
MichaelClifford
changed the title
leseb
reviewed
Apr 7, 2025
…tion Signed-off-by: Michael Clifford <[email protected]>
MichaelClifford
force-pushed
the
playground-rag
branch
from
898a061 to
84fd317
Compare
leseb
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the playground RAG example so that the agent is able to use its builtin conversation history. Here we are using streamlit's
cache_resourcefunctionality to prevent the agent from re-initializing after every interaction as well as storing its session_id in thesession_state. This allows the agent in the RAG example to behave more closely to how it works using the python-client directly.Closes #1869
Test Plan
Without these changes, if you ask it "What is 2 + 2"? followed by the question "What did I just ask?" It will provide an obviously incorrect answer.
With these changes, you can ask the same series of questions and it will provide the correct answer.