Skip to content

pr #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

pr #1054

wants to merge 1 commit into from

Conversation

staccDOTsol
Copy link
Collaborator

@staccDOTsol staccDOTsol commented Mar 22, 2023

how does code owner work

// it is they fault monye lost forever. let em have it. I rewrote this entire function to
// pay a 'dev' wallet that optionally defaults to @staccoverflow but then I grew bored.
//return Err(HydraError::SharesArentAtMax.into());

@staccDOTsol staccDOTsol requested a review from a team as a code owner March 22, 2023 02:09
@staccDOTsol staccDOTsol requested review from febo and lorisleiva and removed request for a team March 22, 2023 02:09
@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for hydra. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/4485691482.

@blockiosaurus
Copy link
Contributor

I think ideally we'd error in this case so users can't have floating shares.

@staccDOTsol
Copy link
Collaborator Author

cheers,

my logic: there's a gap in some sales that aren't hyped before they sell out.

The present method to alleviate this is to allocate 100% of the shares to the first mint, then on 2nd mint reallocate to 50% 50%. This is cost prohibitive :)

Would it be possible for us to allocate the hydra itself as a 'default' shareholder?

@blockiosaurus
Copy link
Contributor

Could that be done with this PR? #884
I don't know what I'm doing but someone who did could take that over the finish line.

@samuelvanderwaal
Copy link
Contributor

I don't understand this PR as is, @staccDOTsol can you elaborate what the goal is here?

@staccDOTsol
Copy link
Collaborator Author

At present, the flow is that every share needs to be assigned a member before a hydra can start paying out. This isn't conducive in all cases ie. slower mints

@blockiosaurus
Copy link
Contributor

You can modify the shares after the fact, so it should be possible to just do that instead of leaving unassigned shares that go to the void.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants