Skip to content

(WIP) ES2015 Transformation #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 31 commits into
base: syntaxkind
Choose a base branch
from

Conversation

joeywatts
Copy link
Collaborator

No description provided.

Neuroboy23 and others added 17 commits August 23, 2018 17:38
Signed-off-by: Joseph Watts <[email protected]>
Signed-off-by: Joseph Watts <[email protected]>
Signed-off-by: Joseph Watts <[email protected]>
Signed-off-by: Joseph Watts <[email protected]>
@joeywatts joeywatts force-pushed the private-name-transformation branch from 6173322 to 4f1a883 Compare August 27, 2018 14:09
@joeywatts joeywatts force-pushed the private-name-transformation branch from c8090dc to fec6ad8 Compare September 11, 2018 18:12
mheiber added a commit that referenced this pull request Dec 17, 2018
Moves the transformation of class properties to the ESNext transformer.

Property initializers are moved to the constructor by the TypeScript transformer only if there is constructor parameter properties. This is to preserve property initialization order.

It currently does not produce void 0 initializers for property declarations that have no initializer due to ESNext and TypeScript having different runtime behaviors. TS completely elides property declarations with no initializer, while I believe the ESNext would define that property on the instance with an undefined value (which is observable at runtime - propertyName in instance or for (var prop in instance) {}).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants