Skip to content

Make most textContent not nullable #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Make most textContent not nullable #1942

wants to merge 5 commits into from

Conversation

alex-kinokon
Copy link

@github-actions GitHub Actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@alex-kinokon
Copy link
Author

@microsoft-github-policy-service agree

saschanaz
saschanaz reviewed Mar 30, 2025
View reviewed changes
Copy link
Contributor

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One thing, given the spec also mentions DocumentFragment, can you also cover that here?

@saschanaz
Copy link
Contributor

(Making it textContent: null; for other Node-inheriting interfaces would be a bonus)

@VisionAustraliaLuis
Copy link

Hello all, is this pull request going to be reviewed so that it can be merged? Thanks!

@alex-kinokon
Copy link
Author

@saschanaz I addressed your feedback. Can’t figure out how to make it null for other interfaces for now so let’s fix that in a future PR.

@alex-kinokon alex-kinokon requested a review from saschanaz May 21, 2025 05:57
@saschanaz
Copy link
Contributor

@saschanaz I addressed your feedback. Can’t figure out how to make it null for other interfaces for now so let’s fix that in a future PR.

Hmm? Any specific reason why DocumentFragment is any different than what you already did?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschanaz saschanaz Awaiting requested review from saschanaz

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Element.textContent should not be nullable
3 participants
@alex-kinokon @saschanaz @VisionAustraliaLuis