Skip to content

VideoEncoderConfig interface should have hevc attribute #2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions baselines/dom.generated.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -771,6 +771,10 @@ interface HashChangeEventInit extends EventInit {
oldURL?: string;
}

interface HevcEncoderConfig {
format?: HevcBitstreamFormat;
}

interface HkdfParams extends Algorithm {
hash: HashAlgorithmIdentifier;
info: BufferSource;
Expand Down Expand Up @@ -2374,6 +2378,7 @@ interface VideoEncoderConfig {
framerate?: number;
hardwareAcceleration?: HardwareAcceleration;
height: number;
hevc?: HevcEncoderConfig;
latencyMode?: LatencyMode;
scalabilityMode?: string;
width: number;
Expand Down Expand Up @@ -30881,6 +30886,7 @@ type GamepadMappingType = "" | "standard" | "xr-standard";
type GlobalCompositeOperation = "color" | "color-burn" | "color-dodge" | "copy" | "darken" | "destination-atop" | "destination-in" | "destination-out" | "destination-over" | "difference" | "exclusion" | "hard-light" | "hue" | "lighten" | "lighter" | "luminosity" | "multiply" | "overlay" | "saturation" | "screen" | "soft-light" | "source-atop" | "source-in" | "source-out" | "source-over" | "xor";
type HardwareAcceleration = "no-preference" | "prefer-hardware" | "prefer-software";
type HdrMetadataType = "smpteSt2086" | "smpteSt2094-10" | "smpteSt2094-40";
type HevcBitstreamFormat = "annexb" | "hevc";
type HighlightType = "grammar-error" | "highlight" | "spelling-error";
type IDBCursorDirection = "next" | "nextunique" | "prev" | "prevunique";
type IDBRequestReadyState = "done" | "pending";
Expand Down
6 changes: 6 additions & 0 deletions baselines/ts5.5/dom.generated.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -771,6 +771,10 @@ interface HashChangeEventInit extends EventInit {
oldURL?: string;
}

interface HevcEncoderConfig {
format?: HevcBitstreamFormat;
}

interface HkdfParams extends Algorithm {
hash: HashAlgorithmIdentifier;
info: BufferSource;
Expand Down Expand Up @@ -2374,6 +2378,7 @@ interface VideoEncoderConfig {
framerate?: number;
hardwareAcceleration?: HardwareAcceleration;
height: number;
hevc?: HevcEncoderConfig;
latencyMode?: LatencyMode;
scalabilityMode?: string;
width: number;
Expand Down Expand Up @@ -30859,6 +30864,7 @@ type GamepadMappingType = "" | "standard" | "xr-standard";
type GlobalCompositeOperation = "color" | "color-burn" | "color-dodge" | "copy" | "darken" | "destination-atop" | "destination-in" | "destination-out" | "destination-over" | "difference" | "exclusion" | "hard-light" | "hue" | "lighten" | "lighter" | "luminosity" | "multiply" | "overlay" | "saturation" | "screen" | "soft-light" | "source-atop" | "source-in" | "source-out" | "source-over" | "xor";
type HardwareAcceleration = "no-preference" | "prefer-hardware" | "prefer-software";
type HdrMetadataType = "smpteSt2086" | "smpteSt2094-10" | "smpteSt2094-40";
type HevcBitstreamFormat = "annexb" | "hevc";
type HighlightType = "grammar-error" | "highlight" | "spelling-error";
type IDBCursorDirection = "next" | "nextunique" | "prev" | "prevunique";
type IDBRequestReadyState = "done" | "pending";
Expand Down
6 changes: 6 additions & 0 deletions baselines/ts5.5/webworker.generated.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,10 @@ interface GetNotificationOptions {
tag?: string;
}

interface HevcEncoderConfig {
format?: HevcBitstreamFormat;
}

interface HkdfParams extends Algorithm {
hash: HashAlgorithmIdentifier;
info: BufferSource;
Expand Down Expand Up @@ -922,6 +926,7 @@ interface VideoEncoderConfig {
framerate?: number;
hardwareAcceleration?: HardwareAcceleration;
height: number;
hevc?: HevcEncoderConfig;
latencyMode?: LatencyMode;
scalabilityMode?: string;
width: number;
Expand Down Expand Up @@ -10409,6 +10414,7 @@ type FrameType = "auxiliary" | "nested" | "none" | "top-level";
type GlobalCompositeOperation = "color" | "color-burn" | "color-dodge" | "copy" | "darken" | "destination-atop" | "destination-in" | "destination-out" | "destination-over" | "difference" | "exclusion" | "hard-light" | "hue" | "lighten" | "lighter" | "luminosity" | "multiply" | "overlay" | "saturation" | "screen" | "soft-light" | "source-atop" | "source-in" | "source-out" | "source-over" | "xor";
type HardwareAcceleration = "no-preference" | "prefer-hardware" | "prefer-software";
type HdrMetadataType = "smpteSt2086" | "smpteSt2094-10" | "smpteSt2094-40";
type HevcBitstreamFormat = "annexb" | "hevc";
type IDBCursorDirection = "next" | "nextunique" | "prev" | "prevunique";
type IDBRequestReadyState = "done" | "pending";
type IDBTransactionDurability = "default" | "relaxed" | "strict";
Expand Down
6 changes: 6 additions & 0 deletions baselines/ts5.6/dom.generated.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -771,6 +771,10 @@ interface HashChangeEventInit extends EventInit {
oldURL?: string;
}

interface HevcEncoderConfig {
format?: HevcBitstreamFormat;
}

interface HkdfParams extends Algorithm {
hash: HashAlgorithmIdentifier;
info: BufferSource;
Expand Down Expand Up @@ -2374,6 +2378,7 @@ interface VideoEncoderConfig {
framerate?: number;
hardwareAcceleration?: HardwareAcceleration;
height: number;
hevc?: HevcEncoderConfig;
latencyMode?: LatencyMode;
scalabilityMode?: string;
width: number;
Expand Down Expand Up @@ -30881,6 +30886,7 @@ type GamepadMappingType = "" | "standard" | "xr-standard";
type GlobalCompositeOperation = "color" | "color-burn" | "color-dodge" | "copy" | "darken" | "destination-atop" | "destination-in" | "destination-out" | "destination-over" | "difference" | "exclusion" | "hard-light" | "hue" | "lighten" | "lighter" | "luminosity" | "multiply" | "overlay" | "saturation" | "screen" | "soft-light" | "source-atop" | "source-in" | "source-out" | "source-over" | "xor";
type HardwareAcceleration = "no-preference" | "prefer-hardware" | "prefer-software";
type HdrMetadataType = "smpteSt2086" | "smpteSt2094-10" | "smpteSt2094-40";
type HevcBitstreamFormat = "annexb" | "hevc";
type HighlightType = "grammar-error" | "highlight" | "spelling-error";
type IDBCursorDirection = "next" | "nextunique" | "prev" | "prevunique";
type IDBRequestReadyState = "done" | "pending";
Expand Down
6 changes: 6 additions & 0 deletions baselines/ts5.6/webworker.generated.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,10 @@ interface GetNotificationOptions {
tag?: string;
}

interface HevcEncoderConfig {
format?: HevcBitstreamFormat;
}

interface HkdfParams extends Algorithm {
hash: HashAlgorithmIdentifier;
info: BufferSource;
Expand Down Expand Up @@ -922,6 +926,7 @@ interface VideoEncoderConfig {
framerate?: number;
hardwareAcceleration?: HardwareAcceleration;
height: number;
hevc?: HevcEncoderConfig;
latencyMode?: LatencyMode;
scalabilityMode?: string;
width: number;
Expand Down Expand Up @@ -10409,6 +10414,7 @@ type FrameType = "auxiliary" | "nested" | "none" | "top-level";
type GlobalCompositeOperation = "color" | "color-burn" | "color-dodge" | "copy" | "darken" | "destination-atop" | "destination-in" | "destination-out" | "destination-over" | "difference" | "exclusion" | "hard-light" | "hue" | "lighten" | "lighter" | "luminosity" | "multiply" | "overlay" | "saturation" | "screen" | "soft-light" | "source-atop" | "source-in" | "source-out" | "source-over" | "xor";
type HardwareAcceleration = "no-preference" | "prefer-hardware" | "prefer-software";
type HdrMetadataType = "smpteSt2086" | "smpteSt2094-10" | "smpteSt2094-40";
type HevcBitstreamFormat = "annexb" | "hevc";
type IDBCursorDirection = "next" | "nextunique" | "prev" | "prevunique";
type IDBRequestReadyState = "done" | "pending";
type IDBTransactionDurability = "default" | "relaxed" | "strict";
Expand Down
6 changes: 6 additions & 0 deletions baselines/webworker.generated.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,10 @@ interface GetNotificationOptions {
tag?: string;
}

interface HevcEncoderConfig {
format?: HevcBitstreamFormat;
}

interface HkdfParams extends Algorithm {
hash: HashAlgorithmIdentifier;
info: BufferSource;
Expand Down Expand Up @@ -922,6 +926,7 @@ interface VideoEncoderConfig {
framerate?: number;
hardwareAcceleration?: HardwareAcceleration;
height: number;
hevc?: HevcEncoderConfig;
latencyMode?: LatencyMode;
scalabilityMode?: string;
width: number;
Expand Down Expand Up @@ -10409,6 +10414,7 @@ type FrameType = "auxiliary" | "nested" | "none" | "top-level";
type GlobalCompositeOperation = "color" | "color-burn" | "color-dodge" | "copy" | "darken" | "destination-atop" | "destination-in" | "destination-out" | "destination-over" | "difference" | "exclusion" | "hard-light" | "hue" | "lighten" | "lighter" | "luminosity" | "multiply" | "overlay" | "saturation" | "screen" | "soft-light" | "source-atop" | "source-in" | "source-out" | "source-over" | "xor";
type HardwareAcceleration = "no-preference" | "prefer-hardware" | "prefer-software";
type HdrMetadataType = "smpteSt2086" | "smpteSt2094-10" | "smpteSt2094-40";
type HevcBitstreamFormat = "annexb" | "hevc";
type IDBCursorDirection = "next" | "nextunique" | "prev" | "prevunique";
type IDBRequestReadyState = "done" | "pending";
type IDBTransactionDurability = "default" | "relaxed" | "strict";
Expand Down
7 changes: 0 additions & 7 deletions inputfiles/removedTypes.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -862,13 +862,6 @@
}
}
},
"VideoEncoderConfig": {
"members": {
"member": {
"hevc": null // Blink only as of 2023-03
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still true, which makes this PR invalid.

Copy link
Author

@yaruno yaruno May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing this for now as above is true. Leaving here note for future reference that hevc codecs are supported on safari browser too, but for some reason they haven't included video encoder config parameters into the webkit browser engine webcodecs implementation for hevc/h265.

}
}
},
"VideoEncoderEncodeOptions": {
"members": {
"member": {
Expand Down
Loading