-
Notifications
You must be signed in to change notification settings - Fork 441
Partially fix crypto.getRandomValues
type param
#2028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
I think fixing CI may require changes in
interface IntegerTypedArrayTypes {
Int8Array: Int8Array;
Int16Array: Int16Array;
Int32Array: Int32Array;
Uint8Array: Uint8Array;
Uint16Array: Uint16Array;
Uint32Array: Uint32Array;
Uint8ClampedArray: Uint8ClampedArray;
}
type IntegerTypedArray = IntegerTypedArrayTypes[keyof IntegerTypedArrayTypes];
interface IntegerTypedArrayTypes {
BigInt64Array: BigInt64Array;
BigUint64Array: BigUint64Array;
} |
Maybe focus on removing null for now? |
@saschanaz can do, any chance of merging/reviewing the upstream PR as well though? Not sure if you're a maintainer for the main TS repo. |
That's not under me, sorry. LGTM for this PR though. |
There was an issue merging, maybe try again saschanaz. Details |
crypto.getRandomValues
type paramcrypto.getRandomValues
type param
lgtm |
Merging because @saschanaz is a code-owner of all the changes - thanks! |
Partial fix for #1194