Skip to content

Partially fix crypto.getRandomValues type param #2028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2025

Conversation

lionel-rowe
Copy link
Contributor

@lionel-rowe lionel-rowe commented May 26, 2025

Partial fix for #1194

Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@lionel-rowe
Copy link
Contributor Author

I think fixing CI may require changes in TypeScript.

es5.d.ts:

interface IntegerTypedArrayTypes {
    Int8Array: Int8Array;
    Int16Array: Int16Array;
    Int32Array: Int32Array;
    Uint8Array: Uint8Array;
    Uint16Array: Uint16Array;
    Uint32Array: Uint32Array;
    Uint8ClampedArray: Uint8ClampedArray;
}

type IntegerTypedArray = IntegerTypedArrayTypes[keyof IntegerTypedArrayTypes];

es2020.bigint.d.ts:

interface IntegerTypedArrayTypes {
    BigInt64Array: BigInt64Array;
    BigUint64Array: BigUint64Array;
}

@saschanaz
Copy link
Contributor

Maybe focus on removing null for now?

@lionel-rowe
Copy link
Contributor Author

Maybe focus on removing null for now?

@saschanaz can do, any chance of merging/reviewing the upstream PR as well though? Not sure if you're a maintainer for the main TS repo.

@saschanaz
Copy link
Contributor

That's not under me, sorry. LGTM for this PR though.

Copy link
Contributor

There was an issue merging, maybe try again saschanaz. Details

@lionel-rowe lionel-rowe changed the title Fix crypto.getRandomValues type param Partially fix crypto.getRandomValues type param May 28, 2025
@saschanaz
Copy link
Contributor

lgtm

@github-actions github-actions bot merged commit d006958 into microsoft:main May 28, 2025
6 checks passed
Copy link
Contributor

Merging because @saschanaz is a code-owner of all the changes - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants