This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Fix the React & Webpack tutorial #765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the default configuration values of Webpack 4 - Switch to ts-loader after experiencing performance degradation with awesome-typescript-loader - Install Webpack as a local package - Move @types into devDependencies
mbertram
changed the title
afzalsayed96
approved these changes
Oct 2, 2018
|
Please merge it |
|
Please merge it |
|
Alright, I've ran through the whole tutorial and it feels like an improvement to me. Thanks @mbertram |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the tutorial eventually results in an error message. Since webpack v4 a CLI has to be installed.
This PR fixes the issue with the missing CLI and also simplifies parts of the configuration.
This possibly supersedes #462.