Skip to content

Don't linearly search for fresh param in getConditionalType #53662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 24, 2023
Merged

Don't linearly search for fresh param in getConditionalType #53662

merged 2 commits into from
May 24, 2023

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Apr 4, 2023 •
edited
Loading

Noticed this while working on #53087.

This loop is effectively just looking for which type parameters are "new" and were introduced by sameMap above. There's no need to do the N^2 behavior, they'll always have the same index.

Not sure this will really affect perf, though.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 4, 2023
@jakebailey
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 4, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the perf test suite on this PR at 771b42d. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..53662
Metric main 53662 Delta Best Worst p-value
Angular - node (v18.10.0, x64)
Memory used 365,442k (± 0.01%) 365,453k (± 0.01%) ~ 365,393k 365,501k p=0.575 n=6
Parse Time 3.38s (± 0.25%) 3.42s (± 0.77%) +0.03s (+ 0.98%) 3.38s 3.45s p=0.031 n=6
Bind Time 1.12s (± 0.36%) 1.12s (± 0.67%) ~ 1.11s 1.13s p=0.389 n=6
Check Time 8.73s (± 0.44%) 8.76s (± 0.34%) ~ 8.71s 8.80s p=0.125 n=6
Emit Time 7.48s (± 0.47%) 7.50s (± 0.67%) ~ 7.42s 7.56s p=0.295 n=6
Total Time 20.71s (± 0.26%) 20.81s (± 0.50%) ~ 20.63s 20.92s p=0.092 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used 191,793k (± 1.22%) 192,692k (± 1.49%) ~ 190,803k 196,470k p=0.936 n=6
Parse Time 1.49s (± 1.77%) 1.50s (± 0.73%) ~ 1.48s 1.51s p=0.800 n=6
Bind Time 0.77s (± 0.67%) 0.78s (± 0.71%) +0.01s (+ 1.09%) 0.77s 0.78s p=0.038 n=6
Check Time 9.61s (± 0.47%) 9.65s (± 0.57%) ~ 9.61s 9.73s p=0.377 n=6
Emit Time 2.75s (± 2.06%) 2.75s (± 0.89%) ~ 2.73s 2.79s p=0.745 n=6
Total Time 14.63s (± 0.64%) 14.68s (± 0.46%) ~ 14.63s 14.78s p=0.147 n=6
Monaco - node (v18.10.0, x64)
Memory used 346,405k (± 0.01%) 346,405k (± 0.00%) ~ 346,386k 346,416k p=0.630 n=6
Parse Time 2.57s (± 0.67%) 2.60s (± 1.00%) ~ 2.57s 2.64s p=0.073 n=6
Bind Time 1.00s (± 1.17%) 1.01s (± 1.45%) ~ 1.00s 1.04s p=0.150 n=6
Check Time 7.07s (± 0.50%) 7.12s (± 0.70%) ~ 7.02s 7.15s p=0.077 n=6
Emit Time 4.21s (± 0.29%) 4.27s (± 0.94%) +0.06s (+ 1.51%) 4.20s 4.30s p=0.029 n=6
Total Time 14.85s (± 0.28%) 14.99s (± 0.67%) +0.15s (+ 1.00%) 14.80s 15.09s p=0.045 n=6
TFS - node (v18.10.0, x64)
Memory used 300,713k (± 0.01%) 300,703k (± 0.01%) ~ 300,673k 300,728k p=0.470 n=6
Parse Time 2.05s (± 1.30%) 2.06s (± 0.97%) ~ 2.03s 2.09s p=0.625 n=6
Bind Time 1.14s (± 0.66%) 1.14s (± 0.78%) ~ 1.13s 1.15s p=0.798 n=6
Check Time 6.55s (± 0.64%) 6.56s (± 0.60%) ~ 6.51s 6.61s p=0.574 n=6
Emit Time 3.84s (± 0.33%) 3.86s (± 0.81%) ~ 3.82s 3.90s p=0.224 n=6
Total Time 13.58s (± 0.41%) 13.63s (± 0.41%) ~ 13.55s 13.72s p=0.258 n=6
material-ui - node (v18.10.0, x64)
Memory used 480,167k (± 0.00%) 480,125k (± 0.01%) -42k (- 0.01%) 480,094k 480,158k p=0.030 n=6
Parse Time 3.08s (± 0.65%) 3.08s (± 1.29%) ~ 3.02s 3.13s p=0.935 n=6
Bind Time 0.91s (± 0.90%) 0.92s (± 2.28%) ~ 0.90s 0.96s p=0.181 n=6
Check Time 17.13s (± 0.25%) 17.24s (± 0.18%) +0.11s (+ 0.64%) 17.21s 17.29s p=0.005 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.12s (± 0.26%) 21.24s (± 0.37%) +0.12s (+ 0.58%) 21.13s 21.35s p=0.024 n=6
xstate - node (v18.10.0, x64)
Memory used 562,088k (± 0.03%) 562,115k (± 0.02%) ~ 561,968k 562,332k p=0.575 n=6
Parse Time 3.79s (± 0.72%) 3.85s (± 0.70%) +0.06s (+ 1.63%) 3.80s 3.88s p=0.013 n=6
Bind Time 1.65s (± 0.51%) 1.65s (± 0.31%) ~ 1.64s 1.65s p=0.666 n=6
Check Time 2.85s (± 1.17%) 2.85s (± 0.60%) ~ 2.82s 2.87s p=0.872 n=6
Emit Time 0.08s (± 0.00%) 0.08s (± 0.00%) ~ 0.08s 0.08s p=1.000 n=6
Total Time 8.37s (± 0.52%) 8.43s (± 0.37%) +0.06s (+ 0.76%) 8.39s 8.47s p=0.037 n=6
Angular - node (v16.17.1, x64)
Memory used 364,816k (± 0.00%) 364,813k (± 0.01%) ~ 364,777k 364,841k p=0.810 n=6
Parse Time 3.54s (± 0.91%) 3.55s (± 0.64%) ~ 3.51s 3.57s p=0.468 n=6
Bind Time 1.18s (± 1.03%) 1.18s (± 0.99%) ~ 1.17s 1.20s p=0.563 n=6
Check Time 9.53s (± 0.18%) 9.58s (± 0.84%) ~ 9.46s 9.69s p=0.092 n=6
Emit Time 7.97s (± 0.34%) 7.98s (± 0.60%) ~ 7.90s 8.02s p=0.747 n=6
Total Time 22.22s (± 0.29%) 22.29s (± 0.61%) ~ 22.09s 22.44s p=0.298 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 192,553k (± 0.03%) 193,079k (± 0.72%) ~ 192,478k 195,922k p=0.575 n=6
Parse Time 1.59s (± 0.76%) 1.59s (± 1.22%) ~ 1.56s 1.61s p=0.806 n=6
Bind Time 0.82s (± 0.50%) 0.83s (± 0.62%) ~ 0.82s 0.83s p=0.112 n=6
Check Time 10.38s (± 0.93%) 10.40s (± 0.38%) ~ 10.34s 10.45s p=0.198 n=6
Emit Time 3.00s (± 0.49%) 2.97s (± 0.69%) -0.03s (- 0.89%) 2.94s 3.00s p=0.032 n=6
Total Time 15.78s (± 0.64%) 15.79s (± 0.26%) ~ 15.73s 15.83s p=0.572 n=6
Monaco - node (v16.17.1, x64)
Memory used 345,677k (± 0.01%) 345,684k (± 0.00%) ~ 345,665k 345,696k p=0.575 n=6
Parse Time 2.71s (± 0.69%) 2.72s (± 0.30%) ~ 2.71s 2.73s p=0.934 n=6
Bind Time 1.08s (± 0.48%) 1.08s (± 0.48%) ~ 1.08s 1.09s p=1.000 n=6
Check Time 7.77s (± 0.33%) 7.77s (± 0.35%) ~ 7.75s 7.82s p=0.871 n=6
Emit Time 4.47s (± 0.74%) 4.46s (± 0.88%) ~ 4.42s 4.53s p=0.332 n=6
Total Time 16.04s (± 0.17%) 16.03s (± 0.24%) ~ 16.00s 16.10s p=0.418 n=6
TFS - node (v16.17.1, x64)
Memory used 300,052k (± 0.00%) 300,054k (± 0.01%) ~ 300,012k 300,091k p=0.873 n=6
Parse Time 2.16s (± 0.19%) 2.17s (± 0.75%) ~ 2.15s 2.19s p=0.491 n=6
Bind Time 1.23s (± 0.80%) 1.24s (± 0.79%) ~ 1.23s 1.25s p=0.136 n=6
Check Time 7.22s (± 0.29%) 7.24s (± 0.48%) ~ 7.19s 7.28s p=0.413 n=6
Emit Time 4.33s (± 0.43%) 4.34s (± 0.49%) ~ 4.31s 4.37s p=0.225 n=6
Total Time 14.93s (± 0.15%) 14.98s (± 0.36%) ~ 14.92s 15.05s p=0.054 n=6
material-ui - node (v16.17.1, x64)
Memory used 479,408k (± 0.01%) 479,404k (± 0.01%) ~ 479,339k 479,436k p=1.000 n=6
Parse Time 3.24s (± 0.30%) 3.26s (± 0.36%) +0.02s (+ 0.62%) 3.24s 3.27s p=0.022 n=6
Bind Time 0.95s (± 0.67%) 0.95s (± 0.88%) ~ 0.95s 0.97s p=0.340 n=6
Check Time 18.20s (± 0.21%) 18.20s (± 0.22%) ~ 18.14s 18.24s p=0.872 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.39s (± 0.16%) 22.41s (± 0.19%) ~ 22.36s 22.47s p=0.685 n=6
xstate - node (v16.17.1, x64)
Memory used 559,726k (± 0.01%) 559,711k (± 0.03%) ~ 559,545k 559,897k p=0.936 n=6
Parse Time 3.98s (± 0.34%) 3.98s (± 0.46%) ~ 3.95s 4.00s p=0.517 n=6
Bind Time 1.74s (± 0.57%) 1.74s (± 0.76%) ~ 1.73s 1.76s p=0.804 n=6
Check Time 3.07s (± 0.34%) 3.07s (± 0.73%) ~ 3.05s 3.11s p=0.292 n=6
Emit Time 0.09s (± 5.53%) 0.10s (± 5.34%) ~ 0.09s 0.10s p=0.311 n=6
Total Time 8.88s (± 0.30%) 8.89s (± 0.37%) ~ 8.84s 8.93s p=0.629 n=6
Angular - node (v14.15.1, x64)
Memory used 358,585k (± 0.01%) 358,599k (± 0.00%) ~ 358,585k 358,612k p=0.199 n=6
Parse Time 3.64s (± 1.21%) 3.66s (± 0.71%) ~ 3.63s 3.70s p=0.466 n=6
Bind Time 1.22s (± 1.37%) 1.22s (± 0.81%) ~ 1.21s 1.23s p=0.601 n=6
Check Time 9.93s (± 0.33%) 9.96s (± 0.20%) ~ 9.93s 9.99s p=0.122 n=6
Emit Time 8.27s (± 0.66%) 8.35s (± 0.93%) ~ 8.22s 8.45s p=0.077 n=6
Total Time 23.06s (± 0.37%) 23.19s (± 0.30%) +0.13s (+ 0.56%) 23.06s 23.26s p=0.025 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used 187,806k (± 0.01%) 187,800k (± 0.01%) ~ 187,772k 187,837k p=0.575 n=6
Parse Time 1.59s (± 0.40%) 1.61s (± 1.04%) +0.02s (+ 1.26%) 1.59s 1.63s p=0.024 n=6
Bind Time 0.85s (± 0.89%) 0.86s (± 0.60%) ~ 0.85s 0.86s p=0.069 n=6
Check Time 10.46s (± 0.67%) 10.48s (± 0.31%) ~ 10.44s 10.52s p=0.872 n=6
Emit Time 3.13s (± 0.75%) 3.13s (± 1.21%) ~ 3.08s 3.18s p=0.747 n=6
Total Time 16.04s (± 0.65%) 16.07s (± 0.34%) ~ 16.00s 16.15s p=0.574 n=6
Monaco - node (v14.15.1, x64)
Memory used 340,676k (± 0.00%) 340,665k (± 0.01%) ~ 340,647k 340,696k p=0.298 n=6
Parse Time 2.83s (± 0.52%) 2.82s (± 0.37%) ~ 2.81s 2.84s p=0.805 n=6
Bind Time 1.10s (± 1.06%) 1.11s (± 1.20%) ~ 1.10s 1.13s p=0.391 n=6
Check Time 8.13s (± 0.25%) 8.12s (± 0.16%) ~ 8.10s 8.13s p=0.222 n=6
Emit Time 4.68s (± 0.99%) 4.71s (± 0.61%) ~ 4.67s 4.75s p=0.298 n=6
Total Time 16.75s (± 0.33%) 16.76s (± 0.24%) ~ 16.71s 16.82s p=0.518 n=6
TFS - node (v14.15.1, x64)
Memory used 295,129k (± 0.00%) 295,120k (± 0.00%) ~ 295,102k 295,130k p=0.172 n=6
Parse Time 2.38s (± 0.90%) 2.41s (± 0.94%) ~ 2.37s 2.43s p=0.104 n=6
Bind Time 1.06s (± 0.00%) 1.07s (± 0.70%) +0.01s (+ 0.79%) 1.06s 1.08s p=0.027 n=6
Check Time 7.54s (± 0.61%) 7.55s (± 0.55%) ~ 7.52s 7.61s p=0.685 n=6
Emit Time 4.30s (± 0.69%) 4.32s (± 0.79%) ~ 4.29s 4.38s p=0.572 n=6
Total Time 15.28s (± 0.34%) 15.34s (± 0.36%) ~ 15.27s 15.43s p=0.109 n=6
material-ui - node (v14.15.1, x64)
Memory used 474,951k (± 0.01%) 474,957k (± 0.01%) ~ 474,889k 474,995k p=0.810 n=6
Parse Time 3.38s (± 0.52%) 3.39s (± 0.55%) ~ 3.36s 3.41s p=0.739 n=6
Bind Time 1.00s (± 0.41%) 1.00s (± 0.75%) ~ 0.99s 1.01s p=0.389 n=6
Check Time 19.21s (± 1.08%) 19.29s (± 0.95%) ~ 19.10s 19.60s p=0.470 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 23.60s (± 0.89%) 23.68s (± 0.84%) ~ 23.48s 24.00s p=0.423 n=6
xstate - node (v14.15.1, x64)
Memory used 548,246k (± 0.00%) 548,264k (± 0.00%) ~ 548,237k 548,297k p=0.261 n=6
Parse Time 4.30s (± 1.79%) 4.32s (± 1.57%) ~ 4.26s 4.41s p=0.295 n=6
Bind Time 1.61s (± 4.25%) 1.63s (± 4.42%) ~ 1.53s 1.68s p=0.370 n=6
Check Time 3.18s (± 0.75%) 3.20s (± 0.47%) ~ 3.18s 3.22s p=0.225 n=6
Emit Time 0.09s (± 5.53%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=0.174 n=6
Total Time 9.19s (± 0.28%) 9.24s (± 0.15%) +0.05s (+ 0.51%) 9.22s 9.26s p=0.005 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 53662 6
Baseline main 6

TSServer

Comparison Report - main..53662
Metric main 53662 Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,393ms (± 0.29%) 2,396ms (± 0.42%) ~ 2,383ms 2,406ms p=0.470 n=6
Req 2 - geterr 5,737ms (± 0.33%) 5,755ms (± 0.61%) ~ 5,716ms 5,802ms p=0.471 n=6
Req 3 - references 335ms (± 0.86%) 335ms (± 0.44%) ~ 332ms 336ms p=1.000 n=6
Req 4 - navto 279ms (± 0.54%) 282ms (± 1.54%) ~ 276ms 287ms p=0.157 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 85ms (± 0.96%) 86ms (± 2.44%) ~ 84ms 90ms p=0.181 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,509ms (± 1.08%) 2,510ms (± 1.48%) ~ 2,462ms 2,552ms p=0.936 n=6
Req 2 - geterr 4,224ms (± 2.00%) 4,279ms (± 0.64%) ~ 4,234ms 4,306ms p=0.093 n=6
Req 3 - references 344ms (± 0.73%) 345ms (± 0.16%) ~ 344ms 345ms p=0.869 n=6
Req 4 - navto 287ms (± 0.78%) 290ms (± 0.51%) +4ms (+ 1.22%) 288ms 292ms p=0.029 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 65ms (± 5.61%) 63ms (± 0.88%) ~ 62ms 63ms p=0.675 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,002ms (± 0.63%) 3,020ms (± 0.75%) ~ 2,979ms 3,045ms p=0.230 n=6
Req 2 - geterr 1,625ms (± 1.25%) 1,621ms (± 1.72%) ~ 1,589ms 1,657ms p=0.810 n=6
Req 3 - references 107ms (± 1.29%) 107ms (± 0.98%) ~ 105ms 108ms p=0.867 n=6
Req 4 - navto 362ms (± 0.28%) 365ms (± 0.62%) +3ms (+ 0.74%) 363ms 369ms p=0.023 n=6
Req 5 - completionInfo count 2,862 (± 0.00%) 2,862 (± 0.00%) ~ 2,862 2,862 p=1.000 n=6
Req 5 - completionInfo 370ms (± 0.92%) 371ms (± 2.54%) ~ 352ms 378ms p=0.147 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,506ms (± 0.86%) 2,518ms (± 0.49%) ~ 2,501ms 2,533ms p=0.377 n=6
Req 2 - geterr 6,181ms (± 0.52%) 6,183ms (± 0.75%) ~ 6,133ms 6,259ms p=1.000 n=6
Req 3 - references 349ms (± 0.42%) 350ms (± 0.71%) ~ 348ms 355ms p=0.411 n=6
Req 4 - navto 279ms (± 1.28%) 281ms (± 1.14%) ~ 278ms 286ms p=0.253 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 91ms (± 0.82%) 91ms (± 0.89%) ~ 90ms 92ms p=0.729 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,666ms (± 0.59%) 2,674ms (± 0.31%) ~ 2,663ms 2,683ms p=0.128 n=6
Req 2 - geterr 4,628ms (± 0.53%) 4,653ms (± 0.51%) ~ 4,623ms 4,682ms p=0.173 n=6
Req 3 - references 357ms (± 0.57%) 358ms (± 0.65%) ~ 356ms 362ms p=0.438 n=6
Req 4 - navto 282ms (± 1.07%) 282ms (± 0.86%) ~ 279ms 286ms p=0.871 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 68ms (± 0.60%) 67ms (± 1.21%) ~ 66ms 68ms p=0.248 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,163ms (± 0.35%) 3,179ms (± 0.47%) ~ 3,159ms 3,204ms p=0.063 n=6
Req 2 - geterr 1,765ms (± 0.94%) 1,777ms (± 1.01%) ~ 1,752ms 1,798ms p=0.336 n=6
Req 3 - references 114ms (± 1.11%) 114ms (± 1.36%) ~ 112ms 115ms p=0.928 n=6
Req 4 - navto 350ms (± 0.21%) 352ms (± 0.49%) +2ms (+ 0.57%) 350ms 354ms p=0.045 n=6
Req 5 - completionInfo count 2,862 (± 0.00%) 2,862 (± 0.00%) ~ 2,862 2,862 p=1.000 n=6
Req 5 - completionInfo 385ms (± 1.72%) 388ms (± 0.60%) ~ 384ms 391ms p=0.747 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,600ms (± 0.47%) 2,615ms (± 0.52%) ~ 2,603ms 2,637ms p=0.093 n=6
Req 2 - geterr 6,423ms (± 2.01%) 6,440ms (± 1.57%) ~ 6,303ms 6,547ms p=0.810 n=6
Req 3 - references 372ms (± 5.36%) 363ms (± 0.93%) ~ 357ms 367ms p=0.374 n=6
Req 4 - navto 281ms (± 1.28%) 284ms (± 1.26%) ~ 280ms 290ms p=0.072 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 97ms (± 8.42%) 94ms (± 8.87%) ~ 81ms 103ms p=0.739 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,803ms (± 0.45%) 2,814ms (± 0.49%) ~ 2,796ms 2,830ms p=0.173 n=6
Req 2 - geterr 4,775ms (± 0.45%) 4,773ms (± 0.39%) ~ 4,754ms 4,795ms p=1.000 n=6
Req 3 - references 367ms (± 0.92%) 367ms (± 0.22%) ~ 366ms 368ms p=0.616 n=6
Req 4 - navto 293ms (± 0.85%) 295ms (± 0.47%) ~ 293ms 296ms p=0.192 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 89ms (± 8.55%) 92ms (± 2.28%) ~ 88ms 94ms p=0.864 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,423ms (± 0.35%) 3,421ms (± 0.56%) ~ 3,387ms 3,446ms p=0.748 n=6
Req 2 - geterr 1,883ms (± 0.91%) 1,883ms (± 0.84%) ~ 1,865ms 1,906ms p=0.810 n=6
Req 3 - references 128ms (± 2.41%) 127ms (± 2.68%) ~ 123ms 131ms p=0.936 n=6
Req 4 - navto 371ms (± 0.56%) 376ms (± 1.39%) ~ 371ms 384ms p=0.089 n=6
Req 5 - completionInfo count 2,862 (± 0.00%) 2,862 (± 0.00%) ~ 2,862 2,862 p=1.000 n=6
Req 5 - completionInfo 417ms (± 1.85%) 413ms (± 1.68%) ~ 407ms 423ms p=0.333 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 53662 6
Baseline main 6

Startup

Comparison Report - main..53662
Metric main 53662 Delta Best Worst p-value
tsc-startup - node (v16.17.1, x64)
Execution time 141.48ms (± 0.20%) 141.92ms (± 0.19%) +0.44ms (+ 0.31%) 141.28ms 147.28ms p=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time 219.28ms (± 0.16%) 220.64ms (± 0.20%) +1.36ms (+ 0.62%) 219.44ms 225.67ms p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 220.80ms (± 0.15%) 222.12ms (± 0.28%) +1.33ms (+ 0.60%) 220.60ms 232.41ms p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time 203.03ms (± 0.17%) 204.20ms (± 0.21%) +1.17ms (+ 0.58%) 202.90ms 208.79ms p=0.000 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 53662 6
Baseline main 6

Developer Information:

Download Benchmark

@jakebailey jakebailey requested a review from weswigham April 6, 2023 19:15
@jakebailey jakebailey merged commit 4c82d91 into microsoft:main May 24, 2023
@jakebailey jakebailey deleted the perf-53087 branch May 24, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser left review comments

@weswigham weswigham weswigham approved these changes

Assignees

@jakebailey jakebailey

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakebailey @typescript-bot @DanielRosenwasser @weswigham