fix(checker): report error when using bigint as enum key #61777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
magic-akari
commented
May 28, 2025
magic-akari
commented
- Fixes enum member key should reject bigint #61772
typescript-bot
added
For Uncommitted Bug
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a diagnostic change in the checker to report an error when a bigint literal is used as an enum key, and updates tests and baseline files accordingly.
- Added a test case (enumWithBugint.ts) that defines an enum using a bigint literal as a key.
- Updated the TypeScript checker logic to emit an error for numeric and BigInt literals used as enum member names.
- Refreshed baseline files (types, symbols, JS, errors) to reflect the updated diagnostic messages.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/cases/compiler/enumWithBugint.ts | New test case to verify error reporting for bigint enum keys |
| tests/baselines/reference/enumWithBugint.{types,symbols,js,errors.txt} | Updated baselines to accommodate the new error message |
| src/compiler/checker.ts | Added error checking for BigInt literals in enum member names |
magic-akari
commented
May 28, 2025
jakebailey
approved these changes
Jun 5, 2025
typescript-bot
removed
the
For Uncommitted Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.