-
Notifications
You must be signed in to change notification settings - Fork 356
Doc WinAppSDK's WinRT registration choice #2359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
While some might call this "non-ideal layout" (implying projections' manifest-free resolution is | ||
ideal), that's not true. The manifest-free option is *simple*, but not necessarily best. As in | ||
WinAppSDK's case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well it depends. It's non-ideal for some projection authors (me). It's very ideal for WinAppSdk for reasons below. Maybe consider striking this as the next paragraph does a good job at preparing the reader for The Big Why™️ after it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just delete and assert what we do and why. No need to defend it. If you are so motivated, you could write an appendix on how projection-based lookup doesn't meet our current needs w.r.t. naming of components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doc reads like a justification of the choice made, not a documentation. "We needed to accomplish X, our options were Q and Y and Z, option Z met the criteria for X."
While some might call this "non-ideal layout" (implying projections' manifest-free resolution is | ||
ideal), that's not true. The manifest-free option is *simple*, but not necessarily best. As in | ||
WinAppSDK's case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just delete and assert what we do and why. No need to defend it. If you are so motivated, you could write an appendix on how projection-based lookup doesn't meet our current needs w.r.t. naming of components.
@DrusTheAxe I can open a separate issue on this if needed, but the embedded fusion manifest requirement appears to deviate from documented expectations, in that a manifest can be embedded as a resource or be on disk, as a fallback. The embedded-only approach that WAS has implemented is a pain for Rust that has no native tooling to embed a manifest. Was this just deemed unnecessary at the time? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This is a polished form of the information in issue #2352 WinAppSdk is difficult to use with reg-free WinRT due to class/file naming, pairs
and particularly in this comment.