PublishSingleFile dll and resources.pri redirection support #4067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #2597 |
… file.loadFrom attributes using them
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JesseCol
reviewed
Jan 16, 2024
There was a problem hiding this comment.
These changes to UndockedRegFreeWinRT -- do we know that the Windows implementation behaves the same way? (on all supported platforms)
There was a problem hiding this comment.
Yes, I've tested with SystemRegFreeWinRT as well (disabling UndockedRegFreeWinRT)
JesseCol
reviewed
Jan 16, 2024
dev/UndockedRegFreeWinRT/catalog.cpp
Outdated
| auto locale = _create_locale(LC_ALL, "C"); | ||
| // Using this pattern intead of calling multiple MoveToAttributeByName improves performance |
JesseCol
reviewed
Jan 16, 2024
| auto locale = _create_locale(LC_ALL, "C"); | ||
| // Using this pattern intead of calling multiple MoveToAttributeByName improves performance | ||
| HRESULT hr = xmlReader->MoveToFirstAttribute(); |
There was a problem hiding this comment.
Presumably, since we change the way we parse things here, we could possibly make a 1.4 app that was working fine fail at runtime when built with 1.5, correct? I'm not saying I see such a problem, I'm just trying to make sure I understand the stakes.
JesseCol
approved these changes
Jan 16, 2024
bpulliam
pushed a commit
that referenced
this pull request
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PublishSingleFile creates a self-extracting exe that deposits embedded files into a temporary folder. As noted in #2597, this causes dll SxS redirection issues, as well as resources.pri lookup issues. The support here (which requires coordinated changes in aggregator) sets a base directory env var, which is used to configure the generated self-contained app.manifest entries to enable custom SxS redirection via the undocumented loadFrom attribute, e.g.:
<asmv3:file name="microsoft.ui.xaml.dll" loadFrom="%MICROSOFT_WINDOWSAPPRUNTIME_BASE_DIRECTORY%microsoft.ui.xaml.dll">