Adding support for .yarnrc.yml files. #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyvv
force-pushed
the
pr/AddYarnRcSupport
branch
from
433cf1a to
4308e49
Compare
dannyvv
commented
Jul 18, 2024
This change factors commonalities between .npmrc and .yarnrc files into a common base class `FileProvider`. This allowed for the addition of .yarnrc.yml files without duplicating code. This caused some of the logic to move around a bit. The biggest change for the npmrc is a more genereralized approach to reading, writing and updating the file without regular expressions and multiple passes.
dannyvv
force-pushed
the
pr/AddYarnRcSupport
branch
3 times, most recently
from
442b318 to
1ea2779
Compare
mismatch in lock file between pnpm 8 and 9
dannyvv
force-pushed
the
pr/AddYarnRcSupport
branch
from
1ea2779 to
99772a8
Compare
jcreamer898
requested changes
Jul 19, 2024
|
You also might wanna just go ahead and run |
dannyvv
force-pushed
the
pr/AddYarnRcSupport
branch
from
dfeb9b6 to
016784a
Compare
I'll add 'lint' support and run prettier seperately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change factors commonalities between .npmrc and .yarnrc files into a common base class
FileProvider.This allowed for the addition of .yarnrc.yml files without duplicating code.
This caused some of the logic to move around a bit. The biggest change for the npmrc is a more genereralized approach to reading, writing and updating the file without regular expressions and multiple passes.
Fixes: #4