-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added error for override parameters undefined issue #20963
base: master
Are you sure you want to change the base?
added error for override parameters undefined issue #20963
Conversation
@v-dko please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
… into users/vdko/azurermtemplaterrorissuefix
@@ -370,8 +370,8 @@ class Utils { | |||
|
|||
try { | |||
overrideParameter.value = this.castToType(overrideParameter.value, template.parameters[overrideParameter.name].type); | |||
} catch (error) { | |||
console.log(tl.loc("ErrorWhileParsingParameter", overrideParameter.name, error.toString())); | |||
} catch (error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong, we shouldn't replace the error message but we need to create a new error message that we will be displayed in a special case when template.parameters[overrideParameter.name] is undefined.
Currently for all possible errors we show only this new error message - which is wrong.
Task name: Update AzureResourceManagerTemplateDeploymentV3 to catch a case when metadata is missing for override parameters (https://dev.azure.com/mseng/AzureDevOps/_workitems/edit/2263340)
Description: added error for override parameters undefined issue
Risk Assesment(Low/Medium/High): Low
Added unit tests: (Y/N) N
Documentation changes required: (Y/N) N
Attached related issue: (Y/N) Y
Checklist: