Fixing logic to pull all files in a PR so release notes can generate properly. #20982
+24
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: NA
Description: The current logic to pull files for PR only return 30 files by default and for large PR it misses the additional files, that leads to wrong release notes. See release notes for 255 and PR 20938 which has 180 files but only 30 files were considered for release notes.
Risk Assesment(Low/Medium/High): Low (this is changing the release pipeline and not changing any task)
Added unit tests: NA
Tests Performed: Tested changes locally as it will generate a new release if tested in actual pipeline.
Documentation changes required: No
Attached related issue: NA
Checklist: