Add initial proposal for cbuffer contexts #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an initial rough proposal for simplifying cbuffers in HLSL 202x.
hekota
reviewed
Apr 29, 2025
| [FXC @ ShaderPlayground](https://shader-playground.timjones.io/22396dd8aec3318b3e9a598c612f156e) | ||
| [DXC @ Compiler Explorer](https://godbolt.org/z/WYK7jvvfP) | ||
|
|
||
| In DXC, `a` and `b` are referenced directly with no namespace qualifications, |
There was a problem hiding this comment.
It is actually possible to reference a and b in DXC by both qualified and unqualifies names as long as the namespace contains more than just a cbuffer: https://godbolt.org/z/Ph57WYexr. Which is clearly a bug.
(filed in microsoft/DirectXShaderCompiler#4514 and microsoft/DirectXShaderCompiler#7322)
hekota
reviewed
Apr 29, 2025
| A `cbuffer` may only be declared at translation unit or namespace scope. A | ||
| `cbuffer` may only contain variable (or empty) declarations. All declarations | ||
| within a `cbuffer` declare names in the immediate enclosing scope. | ||
|
|
There was a problem hiding this comment.
Would it be worth to enumerate types of declarations that will no longer be allowed? Functions, records, static & groupshared var decls...
There was a problem hiding this comment.
And maybe add a note at the beginning that cbuffer should be a collection of constants provided for the shader and that other declarations do not make sense to be included in this context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an initial rough proposal for simplifying cbuffers in HLSL 202x.