-
Notifications
You must be signed in to change notification settings - Fork 44
HLSL goal statement and core priorities #504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
llvm-beanz
wants to merge
8
commits into
microsoft:main
Choose a base branch
from
llvm-beanz:cbieneman/design-guidance
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
650bd91
First rough draft of updated design considerations
llvm-beanz 00adf25
Adding a point about users and some clarification
llvm-beanz fd22f19
Add clarification around portability
llvm-beanz 8fe0dee
Add some clarification around POLA
llvm-beanz 144d4b8
Update docs/DesignConsiderations.md
llvm-beanz b0b5da6
Update docs/DesignConsiderations.md
llvm-beanz 1b1f7ab
Update docs/DesignConsiderations.md
llvm-beanz 0f4c39c
Updating based on PR feedback
llvm-beanz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of HLSL users are also HLSL users. I'm worried that there is no mention of being least astonishing in the context of existing HLSL here. We got significant pushback from some of the C++ features we added. That doesn't mean they were a mistake and we should never bring the languages closer together. I think we need to be thoughtful and cautious about it. To balance what people expect from HLSL versus what they expect from C++. In particular, I'm concerned about extending features in the areas where HLSL differs from C++. The way this is written, we should definitely follow C++ even for a small feature that extends HLSL concepts and ignore how HLSL did them. I think that would be the most astonishing to users and the uglier than continuing how HLSL has done things. That doesn't mean we can't reconsider these approaches, but I'm opposed to special cases that differ from how the rest of HLSL works because it works that way in C++.
As an incomplete example, if we were to extend constant buffers without revising the way they are represented, I think that we shouldn't innovate in their representation even though no one is really fond of that representation.