feat(chromium): improve URL handling for WebSocket endpoint retrieval #36098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code now uses the URL constructor to handle the endpoint URL more robustly. This change ensures that the path is correctly formatted by appending a trailing slash and the 'json/version' segment, avoiding potential errors from manual string manipulation. This improves reliability when retrieving the WebSocket endpoint from the provided URL. Fix microsoft#36097
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Pavel Feldman <[email protected]> Signed-off-by: Zheng Xi Zhou <[email protected]>
Test results for "tests 1"12 flaky39281 passed, 808 skipped Merge workflow run. |
|
@pavelfeldman Thank you for your suggestion. Now all UTs passed. |
pavelfeldman
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code now uses the URL constructor to handle the endpoint URL more robustly. This change ensures that the path is correctly formatted by appending a trailing slash and the 'json/version' segment, avoiding potential errors from manual string manipulation. This improves reliability when retrieving the WebSocket endpoint from the provided URL.
Fix #36097