Bump folly to 2024.10.14.00 #14532
Open
Bump folly to 2024.10.14.00 #14532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TatianaKapos
changed the title
|
The folly CGManifest will need to be updated with the fast_float information. |
acoates-ms
reviewed
Apr 16, 2025
jonthysell
requested changes
Apr 21, 2025
microsoft-github-policy-service
bot
added
the
Needs: Author Feedback
microsoft-github-policy-service
bot
removed
the
Needs: Author Feedback
TatianaKapos
commented
Apr 22, 2025
| @@ -183,10 +186,19 @@ | |||
| </ClInclude> | |||
| <ClInclude Include="$(FollyDir)\folly\dynamic-inl.h"> | |||
There was a problem hiding this comment.
These files still exist but they just include the new files to not break dependencies (see: facebook/folly@cb47968#diff-392b91b8b87bb9159b6158d7a291dad8884feabc65719bf737a010a6f7334511). Opted to keep them until these get removed.
jonthysell
reviewed
Apr 23, 2025
jonthysell
reviewed
Apr 23, 2025
jonthysell
reviewed
Apr 23, 2025
| @@ -5,12 +5,9 @@ | |||
| ; ************************************************************************************************** | |||
|
|
|||
| EXPORTS | |||
| ??0dynamic@folly@@QEAA@$$QEAU01@@Z | |||
There was a problem hiding this comment.
@acoates-ms Does this look right?
|
Meta looks like they backported their bump to folly to 0.76, 0.77, and 0.78. We will want to do the same once this PR gets merged in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumps Folly to match upstream version
Folly Version: https://github.com/facebook/folly/tree/ad90720829db5ba0c3d0e44994856dcce33d7940
Upstream commit: https://github.com/facebook/react-native/pull/47033/files - upstream added a dependency on fast_float - added a step in Folly project to download into nod_modules/.folly similar to how we download folly.
Notable Changes
facebook/folly@cb47968#diff-0ec3993b1fb649bc1e8fee83923ebbcf2276ae2fa992adf74b88d37883e9b7a8
facebook/folly@1dfdd84#diff-113d41382192f50410ae54d74002505dbf826502f80ac8d6b5c72cda3cae3cd2
Why
Resolves #14453
Testing
Tested building projects locally
Changelog
Yes - Upgrades Folly to 2024.10.14.00
Microsoft Reviewers: Open in CodeFlow