.Net: Net MEVD: Sqlite escape table and column names, treat empty batches as NOP #11252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
adamsitnik
had a problem deploying
to
integration
GitHub Actions
Failure
westey-m
approved these changes
Mar 31, 2025
roji
requested changes
Apr 1, 2025
| @@ -15,6 +15,6 @@ internal abstract class SqliteWhereCondition(string operand, List<object> values | |||
| public abstract string BuildQuery(List<string> parameterNames); | |||
|
|
|||
| protected string GetOperand() => !string.IsNullOrWhiteSpace(this.TableName) ? | |||
| $"{this.TableName}.{this.Operand}" : | |||
| this.Operand; | |||
| $"[{this.TableName}].[{this.Operand}]" : | |||
There was a problem hiding this comment.
In SQLite, the standard quoting mechanism is double-quoted (the square brackets is more of a SQL Server thing). In fact I'm surprised this works!
Also, don't we need to escape TableName and Operand, in case they contain special characters?
I'd maybe suggest having a single method somewhere (RenderSqlIdentifier?) which does the quoting and escaping, and used from everywhere (for column, table, index names...).
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11251
contributes to #10194