Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: feat: Added support for .yml extensions in C# SDK #11324

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

WretchedDade
Copy link

Updated CreatePluginFromPromptDirectoryYaml to support files with both .yaml AND .yml extensions.

Motivation and Context

This fixes #11322 by adding support for the .yml file extensions when loading YAML files from a directory in the C# SDK.

Description

Updated the CreatePluginFromPromptDirectoryYaml method to load files from the plugin directory twice. Once with the *.yaml search pattern as before, and once with the *.yml search pattern.

Updated the tests to include a file with the .yml extension to ensure that the method works as expected and compatibility isn't lost in the future.

Contribution Checklist

Updated CreatePluginFromPromptDirectoryYaml to support files with both .yaml AND .yml extensions.
@WretchedDade WretchedDade requested a review from a team as a code owner April 1, 2025 20:33
@markwallace-microsoft markwallace-microsoft added the .NET Issue or Pull requests regarding .NET code label Apr 1, 2025
@github-actions github-actions bot changed the title feat: Added support for .yml extensions in C# SDK .Net: feat: Added support for .yml extensions in C# SDK Apr 1, 2025
@WretchedDade
Copy link
Author

Looks like I forgot to push the change of removing the blank line to appease the formatter. I have pushed that change now.

@WretchedDade
Copy link
Author

For some reason the format action still failed, for .Net 8 specifically. I ran dotnet format locally and it didn't change anything 🤷🏻. The complaints came from the lines where I was spreading the arrays in the collection initializer, so I converted that to simply .Concat(...) them. Hopefully that will appease the formatter. Can you reapprove @markwallace-microsoft?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: CreatePluginFromPromptDirectoryYaml doesn't support YAML files using .yml extensions
2 participants