.Net: Fix timezone bug in qdrant datetime unit tests. #11407
Merged
+13
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
SergeyMenshykh
approved these changes
Apr 7, 2025
RogerBarreto
approved these changes
Apr 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
shethaadit
approved these changes
Apr 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@westey-m please see #11391 (comment), I do believe we should consider a behavior change here, rather than just viewing it as a test issue. |
… better to DateTimeOffset.
SergeyMenshykh
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#11391
Description
Fix timezone bug in qdrant datetime unit tests.
Revert datetime support since Qdrant's date time support is more suited to DateTimeOffset
May add support for DateTime (UTC) later, based on design that is to be agreed.
Contribution Checklist