.Net: Use ChatHistoryAgentThread with OpenAIResponseAgent #11499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
markwallace-microsoft
had a problem deploying
to
integration
GitHub Actions
Failure
markwallace-microsoft
force-pushed
the
users/markwallace/response_agent_thread_update
branch
from
9685eff to
3c39c4e
Compare
markwallace-microsoft
temporarily deployed
to
integration
GitHub Actions
Inactive
westey-m
approved these changes
Apr 11, 2025
| } | ||
|
|
||
| /// <summary> | ||
| /// Initializes a new instance of the <see cref="OpenAIResponseAgentThread"/> class that resumes an existing response. | ||
| /// </summary> | ||
| /// <param name="client">The agents client to use for interacting with responses.</param> | ||
| /// <param name="id">The ID of an existing response to resume.</param> | ||
| /// <param name="enableStore">Enable storing messages on the server.</param> | ||
| public OpenAIResponseAgentThread(OpenAIResponseClient client, string id, bool enableStore = false) | ||
| public OpenAIResponseAgentThread(OpenAIResponseClient client, string id) |
There was a problem hiding this comment.
nit.
Is this experimental? Can we change this? suggest using responseId here, not clear what id this is referring to.
Suggested change
| public OpenAIResponseAgentThread(OpenAIResponseClient client, string id) | |
| public OpenAIResponseAgentThread(OpenAIResponseClient client, string responseId) |
There was a problem hiding this comment.
Yes, the entire package is experimental, I'll make this change
RogerBarreto
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Response to this suggestion:
Instead of having a StoreEnabled on the agentThread, consider supporting two thread types, e.g. ChatHistoryAgentThread and OpenAIResponseAgentThread.
Description
Contribution Checklist