feat: only-on-ready #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First successful run now that the app has been approved. |
|
@azchohfi let me know if you need more context or how I can help. |
|
I want to hold on merging this for a little bit since I want the review of another team member that maintains the REST APIs. Thanks for the PR, and your patience! |
azchohfi
requested changes
Oct 28, 2022
I've done a review myself. Wait until next week and I'll get back with a resolution for this. |
|
@azchohfi I'll try to have a look over the weekend. Thanks. |
JanDeDobbeleer
force-pushed
the
submission-status
branch
2 times, most recently
from
aa9e9e2 to
cd65bf3
Compare
JanDeDobbeleer
force-pushed
the
submission-status
branch
from
cd65bf3 to
77a5631
Compare
|
@azchohfi any chance for a review? |
|
@floh96 I'm still using my fork 😅 Works like a charm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted a way to run this on a release trigger without failing. As I release quite often, and the review period is longer than my increments, I came up with this solution which adds one parameter to the authenticate command and is reused cross command. In case
only-on-readyis set totrue, any try at pushing will simply be aborted until the current submission is approved and in the store. You can see it in action here.I can keep using my fork, or work on this together if you think it's useful.