Disable some Compose features if Docker's extension is installed #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker's extension bundles a language server that provides some Compose features that overlap with the ones from the Container Tools extension. Red Hat's YAML extension also does something similar which was previously accounted for. The code has now been changed to disable select Compose features if Docker's extension or Red Hat's YAML extension is installed. Signed-off-by: Remy Suen <[email protected]>
|
@bwateratmsft I've converted this to a draft for now. Will switch it back after we've figured out the coordination of things to ensure things are generally smooth and non-disruptive. |
|
Sounds good. Code looks great, thanks @rcjsuen! |
bwateratmsft
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker's extension bundles a language server that provides some Compose features that overlap with the ones from the Container Tools extension. Red Hat's YAML extension also does something similar which was previously accounted for. The code has now been changed to disable select Compose features if Docker's extension or Red Hat's YAML extension is installed.
To test this, one should install specific builds of Docker's extension that are being generated by docker/vscode-extension#108.