Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "Add function for checking and caching GitHub Tokens" (#236266) #236478

Merged
merged 9 commits into from
Mar 28, 2025

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Mar 10, 2025

@Trenly Trenly requested review from denelon and a team as code owners March 10, 2025 19:14
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Mar 10, 2025
@denelon
Copy link
Collaborator

denelon commented Mar 10, 2025

@AmelBawa-msft could you take a look at this one?

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Mar 10, 2025
@Trenly
Copy link
Contributor Author

Trenly commented Mar 10, 2025

@denelon - This matches the latest guidance from winget-create where a specific environment variable is used instead of the -token argument

microsoft/winget-create@c79d2ee

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Mar 16, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Moderator-Approved One of the Moderators has reviewed and approved this PR label Mar 17, 2025
@Trenly
Copy link
Contributor Author

Trenly commented Mar 26, 2025

[Policy] Needs Manual Merge

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Manual-Merge The pull request requires a manual merge from a repository maintainer Needs-Attention This work item needs to be reviewed by a member of the core team. labels Mar 26, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Mar 27, 2025
@stephengillie
Copy link
Collaborator

Error:
{
"message": "Repository rule violations found\n\nAt least 1 approving review is required by reviewers with write access.\n\nNew changes require approval from someone other than the last pusher.\n\n",
"documentation_url": "https://docs.github.com/rest/pulls/pulls#merge-a-pull-request",
"status": "405"
} - Url - Body: {"merge_method":"squash","sha":"92502ffc669baedd00df2889c4bb707c826c9ccf"}

@stephengillie stephengillie merged commit fa9ebd5 into microsoft:master Mar 28, 2025
2 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Mar 28, 2025
@Trenly Trenly deleted the ScriptAnalyze branch March 28, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Manual-Merge The pull request requires a manual merge from a repository maintainer Project-File
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants